qa/232 was failing on Centos 7.
There are NR_RPC4_SVR_COUNTERS instances, numbered 1 (not 0) to
NR_RPC4_SVR_COUNTERS, but the values are stored in [0] ...
[NR_RPC4_SVR_COUNTERS-1] of proc_net_rpc->server.reqcounts4[].
It would be _really_ good to have someone who knows the nfs code in the linux
pmda to review these changes, and if they are correct to check that similar
mismatches are not happening for the other nfs/rpc metrics.
Changes committed to git://git.performancecopilot.org/kenj/pcp.git dev
src/pmdas/linux/pmda.c | 6 +++---
src/pmdas/linux/proc_net_rpc.c | 15 ++++++++++++---
2 files changed, 15 insertions(+), 6 deletions(-)
commit 56281b7d3e56bd6b8fdfcb819bc08dea9b8fbde1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Oct 7 16:35:14 2014 +1100
linux pmda - nfs4 metrics
The indom for server requests for NFSv4 was not being handled correctly.
When nfsd was started and supporting NFSv4, qa/232 was failing because
pminfo -f was not returning the last member of the instance domain.
|