Hi,
On 2014-09-24 09:53, Marko Myllynen wrote:
> On 2014-09-23 07:45, Nathan Scott wrote:
>
>> Yes, we'll definitely want to be doing that :) & in an automated fashion.
>> A test just like the memcached test qa/835 will be needed - any interest in
>> tackling that to finish this PMDA off?
>
> I'll try to take a look at it in the coming days but please feel finish
> it off before that :)
actually, I had a quick look at this already. I think it's doing basic
sanity checking already very well and if 389 DS reports unexpected
values then there's not much the PMDA could do about it. If 389 DS is
not responding, the PMDA should be able to cope with that (fails loudly
if connection setup or bind fails, later on simply does not update
metrics if searches fail). I think we can also trust Net::LDAP to work
without issues.
Perhaps we can revisit this later if there are any sorts of issues
reported with the PMDA.
Thanks,
--
Marko Myllynen
|