pcp
[Top] [All Lists]

pcp updates - error handling and diags in the linux proc pmda

To: pcp@xxxxxxxxxxx
Subject: pcp updates - error handling and diags in the linux proc pmda
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue, 23 Sep 2014 19:46:24 +1000
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1
Changes committed to git://git.performancecopilot.org/kenj/pcp.git dev

 qa/admin/check-vm               |   10 -
 src/pmdas/linux_proc/pmda.c     |   57 ++----
 src/pmdas/linux_proc/proc_pid.c |  365 ++++++++++++++++++++++++++++------------
 src/pmdas/linux_proc/proc_pid.h |   18 -
 4 files changed, 295 insertions(+), 155 deletions(-)

commit 85d06e790e6c5ecda755f718a7b6db10a20bb5a9
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Sep 23 19:38:14 2014 +1000

    linux_proc pmda - refactor procfs error handling
    
    Clean up the error handling
    - be algorithmicly consistent across all the fetch_* methods
    - confine the system call error code mapping to a new maperr()
      static function
    
    Note, this makes the error handling sane and consistent.  It is unclear
    what the access control semantics should be.  With this change, the
    Linux proc PMDA returns the following info ...
    
    - all processes if installed as a daemon PMDA and run as root
    - all processes belonging to the uid of user "pcp" if installed
      as a DSO PMDA (needs special hacking as the default Install
      script does not support this mode of installation)
    - all processes belonging to the user if using PM_CONTEXT_LOCAL,
      e.g. with -L and -K to pminfo
    
    If this is not what's expected, we need to talk.

commit a0716b6c95c82c00648ca04f58a63e5d2b68568c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Sep 23 19:37:52 2014 +1000

    qa/admin/check-vm - tweak list of things to check

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates - error handling and diags in the linux proc pmda, Ken McDonell <=