pcp
[Top] [All Lists]

Re: [pcp] [PATCH] 389 DS PCP PMDA

To: myllynen@xxxxxxxxxx
Subject: Re: [pcp] [PATCH] 389 DS PCP PMDA
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 23 Sep 2014 00:45:52 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx, Rich Megginson <rmeggins@xxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <541C1297.6050009@xxxxxxxxxx>
References: <541C1297.6050009@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: ogot14jyeIvuWjgQR4IOcRWGtWQEvA==
Thread-topic: 389 DS PCP PMDA
Hi Marko,

----- Original Message -----
> [...]
> below is a 389 Directory Server PMDA, ds389, tested on RHEL 6
> (389-ds-base-1.2.11) / Fedora 20 (389-ds-base-1.3.2). It provides server and
> database (userRoot) metrics [...]

Awesome - thanks for putting this together!

> The only real concern I have at the moment is the need for the
> query_interval/timestamp stuff which is pretty ugly but when doing e.g.
> "pminfo -dfmtT ds389.userroot" two successive queries are done for some
> reason, I think we should avoid such needless LDAP queries.

You may find this is as a result of the query "batchsize" concept within
pminfo - see the -b,--batch option.  If this is indeed the cause, you'll
find the fetch routines are passed sets of metrics, & the PMDA can respond
to just those requested (as this one does, to an extent, with use of the
PMID cluster field).  Specific sub-trees can be queried via ds389.userroot
or ds389.cn and you should see only those LDAP queries fire off.

> If you want to test this locally, just install the 389-ds-base RPM and run
> setup-ds.pl and you'll have 389 DS up and running.

Yes, we'll definitely want to be doing that  :)  & in an automated fashion.
A test just like the memcached test qa/835 will be needed - any interest in
tackling that to finish this PMDA off?

I found the perl-LDAP package is also needed - the Install script could be
tweaked to check for this.  We'll also need to stitch this into the build
via a new makefile, and assign a domain number.  I'll take on these last
few, but would love some testing help if you can.  If not, I'll come back
to that as soon as I can too.  For now, I've merged in your initial patch
so that we have a common starting point (not built/installed yet though).

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>