pcp
[Top] [All Lists]

Re: [pcp] Context switch metrics

To: Martins Innus <minnus@xxxxxxxxxxx>
Subject: Re: [pcp] Context switch metrics
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 22 Sep 2014 02:36:30 -0400 (EDT)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <541C7F5E.4030809@xxxxxxxxxxx>
References: <541C7F5E.4030809@xxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: cgdsuZKOckISea4BcFKTaDsZ97fyTw==
Thread-topic: Context switch metrics
Hi Martins,

----- Original Message -----
> Hi,
> I have updated the linux_proc pmda to add the context switch metrics from
> /proc/<pid>/status. I did it on a forked pcp tree from github. How would you
> prefer changes from there? I'm fairly new to github. Should I generate a
> pull request? It is commit:
> 
> 2e5eebf25705eaf81cca089a68473443eabbdc2e
> 
> from:
> 
> github.com/ubccr/pcp
> 
> branch: martins-working
> 

Sending mail to the pcp list as you've done is fine - it gives everyone a chance
to review (all developers hang out here).  Put as much information in the email
as you like - diffstat, commit logs - everything helps get the message across, &
git-log(1) has many options to help produce neat summaries.

However, if a github pull request follows yours / someone elses workflow better,
that's fine with me as well.

Thanks Martins - I'll review & merge tomorrow unless someone gets to it before 
me.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>