Hi -
> [...]
> FWIW, other things I'd be looking for when I'm reviewing would be :-
> are new tests needed or is extension fine [...]
The qa/660 test includes coverage of the new code, and increased
coverage of the old.
> I just noticed mention above of "more useful [config file] format" -
> set an alarm bell ringing - is that a backwards-compatible change?
> (and which standard is referred to - the usual pcp .options format?
> [...]
Yup, and no, it is not backward compatible. I was a bit torn whether
to make it possible to consume both the new format and the old, but
thought that this file contains such small amount of info, and local
changes would show up as conflicts at the package-update point and of
course at run time, that it was not a big deal. If you feel strongly,
I could patch back in the sed-goop'ing, on a heuristic basis. The new
format (really, the old unix-style sourced-bourne-shell snippet) is
compelling, e.g. in that it allows $PCP_FOO* var expansions in the
options.
- FChE
|