pcp
[Top] [All Lists]

pcp update: telnet-probe bug

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: pcp update: telnet-probe bug
From: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Date: Thu, 18 Sep 2014 14:13:26 -0400
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
Hi -

Please enjoy this ditty from pcpfans.git, found while doing pmwebd qa.


commit 202032bf3d8ac1306dfda4b268a4a6fc798232b3 (HEAD, pcpfans/fche/dev, 
fche/dev)
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Sep 18 14:09:52 2014 -0400

    telnet-probe: fix byte-by-byte copying
    
    During the transition to the NSS libraries, a __pmWrite call replaced
    a fputc when transcribing bytes to/from the remote socket.  This was
    broken because the parameter to __pmWrite was an int rather than a
    char, and so instead of sending 'a', telnet-probe sends 'a\0\0\0'.
    Similarly on the socket-receive side, we tried to read ints rather than
    chars via __pmRead.  We now narrow the int-carrying values to chars
    where they belong.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp update: telnet-probe bug, Frank Ch. Eigler <=