pcp
[Top] [All Lists]

pcp updates - mysql pmda and freebsd changes

To: pcp@xxxxxxxxxxx
Subject: pcp updates - mysql pmda and freebsd changes
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu, 28 Aug 2014 08:38:39 +1000
Cc: Gareth Humphries <gareth.humphries@xxxxxxxxxxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0
I now have QA -g sanity passing on FreeBSD.

Changes committed to git://git.performancecopilot.org/kenj/pcp.git dev

 build/tar/checkmodes           |   46 +++++++++++++++++++++++++++++++++++++++++
 qa/common                      |   15 +++++++++++++
 src/libpcp/src/logportmap.c    |    6 +++++
 src/libpcp/src/util.c          |   16 ++++++++++++--
 src/pmdas/mysql/pmdamysql.pl   |    4 +--
 src/pmlogger/pmlogger_daily.sh |   35 ++++++++++++++++++++++++++++---
 6 files changed, 115 insertions(+), 7 deletions(-)

commit 8de75d1cf5443f3d5ca05065f84dc68f3439fbc1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Aug 28 08:32:22 2014 +1000

    mysql PMDA - change metric semantics for "uptime"
    
    The metrics mysql.status.uptime and
    mysql.status.uptime_since_flush_status do count time, but their
    most common use is as a value, rather than a rate converted metric.
    Change the semantics from PM_SEM_COUNTER to PM_SEM_INSTANT.
    
    This matches the semantics of other "uptime" metrics, like
    kernel.all.uptime.
    
    Thanks to Gareth Humphries at MessageMedia for pointing this out.

commit 67c4c2d01f229440066077d77c8b65dd84ac82c0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Aug 28 08:06:42 2014 +1000

    pmlogger_daily.sh - bizarre difference in find(1) semantics
    
    The comment from the code should suffice!
    
        # FreeBSD semantics for find(1) -mtime +N are "rounded up to
        # the next full 24-hour period", compared to GNU/Linux semantics
        # "any fractional part is ignored".  So, these are almost always
        # off by one day in terms of the files selected.
        # For consistency, try to match the GNU/Linux semantics by using
        # one MORE day.

commit e13a4c5823eb24dcb4ea0293a35421773341cea4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Aug 28 07:21:21 2014 +1000

    libpcp/util.c - FreeBSD changes
    
    1. cast to avoid compiler warning in alternate strchrnul()
    2. new implementation of __pmProcessExists() for FreeBSD.

commit 074340d6b5b1a4da2df95fd34c44b23bfb005f0d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Aug 28 07:19:51 2014 +1000

    libpcp/logportmap.c - one additional diagnostic.
    
    Helped deugging on FreeBSD, may be useful elsewhere.

commit 3deb4f6fe061981f97f8545899e676287f827805
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Aug 28 07:17:42 2014 +1000

    qa/common - guess the name of gmake(1)
    
    On FreeBSD, having to do MAKE=gmake check ... all the time is a
    pain.  The real path to GNU make is hidden in builddefs, but not
    used anywhere (before this change).

commit 2effc0b653f300136ef0f3d036896ac983fdecb3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Aug 28 07:16:03 2014 +1000

    build/tar/checkmodes - helper script to check file modes and ownership
    
    Uses the Debian packaging recipe as a reference, and checks if the
    local install has the same pcp:pcp and pcpqa:pcpqa ownership and
    mode settings for files and directories.

<Prev in Thread] Current Thread [Next in Thread>