pcp
[Top] [All Lists]

pmdagfs2: updates

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: pmdagfs2: updates
From: Paul Evans <pevans@xxxxxxxxxx>
Date: Tue, 26 Aug 2014 18:56:15 +0100
Cc: PCP Mailing List <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Changes committed to git://github.com/pauljevans/pcp.git dev

 qa/654.out                   |    2 +-
 qa/655                       |   14 +-
qa/655.out | 2082 ++++++++++++++++++++++++++++++++++++------
 qa/common.gfs2               |    2 +-
 src/pmdas/gfs2/GNUmakefile   |   21 +-
 src/pmdas/gfs2/control.c     |    4 +
 src/pmdas/gfs2/control.h     |    1 +
 src/pmdas/gfs2/ftrace.c      |   25 +-
 src/pmdas/gfs2/help          |  138 ++-
 src/pmdas/gfs2/latency.c     |  373 ++++++++
 src/pmdas/gfs2/latency.h     |   70 ++
 src/pmdas/gfs2/pmda.c        |  105 ++-
 src/pmdas/gfs2/pmdagfs2.h    |    7 +-
 src/pmdas/gfs2/pmns          |   74 +-
 src/pmdas/gfs2/worst_glock.c |   88 +-
 src/pmdas/gfs2/worst_glock.h |    2 -
 16 files changed, 2609 insertions(+), 399 deletions(-)

commit 5253d13c23b63a02da12d3298768107b76f5d657
Author: Paul Evans <pevans@xxxxxxxxxx>
Date:   Tue Aug 26 18:46:11 2014 +0100

    pmdagfs2: Add a set of glock latency metrics values

Add a new set of latency metrics for glock grant, demote and queue requests. These latency metrics are split to include a value for each lock type for
    each CPU; Values are calculated through the GFS2 tracepoints and are
    measured in micro-seconds (usecs) for each individual lock type.

Updated the qa tests 654 and 655 to both test and reflect these new metrics.

    Have also performed some small cleanups:
- Remove worst_glock.h ARRAY SIZE DEFINE (Missed in re-factorisation)
        - Static function worst_glock_assign_glocks in worst_glock.c
        - Fix comment in worst_glock.c worst_glock_set_state

All of the patches have been tested and have had covscan run on them. As always
please let me know if there are any issues and feedback is welcome :)

Cheers,

Paul

<Prev in Thread] Current Thread [Next in Thread>