Hi Paul,
----- Original Message -----
> Changes committed to git://github.com/pauljevans/pcp.git dev
> [...]
> Also includes the fixes to pass qa test 469, all of the patches have
> been tested and have had covscan run on them.
Fabulous, thanks!
> As always please let me know if
> there are any issues and feedback is welcome :)
Small stuff only, as always - how does the attached patch look to you?
It has the following two little changes:
- the gfs2.control metrics seem to be defined as U32, so we should put
'em into the pmAtomValue "ul" field (this only becomes visible on big
endian boxes, benign otherwise). gfs2_control_check_value comment is
updated to match its existing return code behaviour.
- tweaks an explicit tracing file location to use the table, and also
get the compiler to work out the string size instead of hard-coding
it in the strncmp call (40).
Feel free to merge it into your tree if it looks ok & I'll pull from
there.
cheers.
--
Nathan
gfs2.patch
Description: Text Data
|