Hey Mark,
----- Original Message -----
> > [...]
> > (I'm not a huge fan of $PCP_QA_ESTIMATE_MEMAVAILABLE, FWIW - seems a
> > roundabout kind of way to check the value, the above two suggestions
> > might be simpler? - *shrug* - your call of course).
>
> I was planning to just do something like this :
>
> grep -q MemAvailable /proc/meminfo || notrun
> k=$(pmprobe -Lv mem.util.available | awk '{print $NF}')
> u=$(PCP_QA_ESTIMATE_MEMAVAILABLE=1 pmprobe -Lv mem.util.available |\
> awk '{print $NF}')
>
> and then check $k and $u are within 1% (which is near enough?), but
> if you think the envvar to too hacky, then we can check it some other
> way.
It seems a little hacky but that might just be me - this is code that's
going to live forever incore in pmdalinux right? (its not enhancing the
code readability in that spot either :) ... *shrug*, its probably just
me be being a bit picky there).
The derived metrics approach would seem to be about the same level of
complexity to the above QA snippet, and relies on the test being run
on the many different platforms we use, to get the coverage we want
without that extra code in pmdalinux.
Up to you - not a big deal at all, just a suggestion.
cheers.
--
Nathan
|