pcp
[Top] [All Lists]

Re: [pcp] pmServiceDiscoveryInterrupt() commit a8b87e2 et al.

To: Dave Brolley <brolley@xxxxxxxxxx>
Subject: Re: [pcp] pmServiceDiscoveryInterrupt() commit a8b87e2 et al.
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 26 Jun 2014 00:51:02 -0400 (EDT)
Cc: "Frank Ch. Eigler" <fche@xxxxxxxxxx>, pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <53AB0F27.602@xxxxxxxxxx>
References: <20140619194444.3B03D58015@xxxxxxxx> <53AB0F27.602@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: ffutv/gucp+CESDcoUzmgcNZsjS54A==
Thread-topic: pmServiceDiscoveryInterrupt() commit a8b87e2 et al.

----- Original Message -----
> [...]
> Thanks for the review! Although I have addressed each item with the
> relevant commits, it would probably be best to review the code after
> merging all of them, since some aspects of the API evolved as the work
> items progressed. Also, man pages will be updated once we have agreement
> on the API.

(/me cheers from the side-lines) ... looking good Dave.

> There is now a new expanded API, pmDiscoverServicesAdvanced(1) -- name
> is not set in stone should anyone be able to think of a better one. See

pmDiscoverServicesExtended(3)?  (or Expanded?).

Also, the whitespace police called and sent through the attached patch
(and make some persnickety comments about that new function in pmfind.c).

cheers.

--
Nathan

Attachment: whitey.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>