On 05/30/2014 03:23 AM, Nathan Scott wrote:
Cool - it was still failing for me though. :) Pls double check my changes
to 775 and 946 (deterministic output for both the case where there are and
are not remote pmproxy/pmwebd services found).
Its merged in dev now - I do see failures on the new tests (766 & 776), I
think these are ifconfig output differences between our text boxen? Can
we use pminfo/pmprobe on network.interface.{inet_addr,ipv6_addr} instead,
to get platform independence? Else we'll need updated filtering - I'll
send through my ifconfig output here privately if you prefer that route.
Your changes to 775 and 946 look good. So good that I stole them for 766
and 776 :-)
I also changed 766 and 776 to use pminfo in order to obtain the address
of an active interface. Pushed to brolley/dev on pcpfans as
commit d7ed4e206d21c81a6d3b5627efceb02b94df94b5
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri May 30 15:09:55 2014 -0400
Make qa tests 766 and 776 (pmfind with active probing) more robust.
- Stole Nathan's deterministic output fix from tests 775 and 946
- Use pminfo to obtain the address of an active interface instead
of ifconfig (also Nathan's suggestion).
Ohhhh ... wait, one other thought. With pmfind in "--all" mode - i.e.
probing freakin' anything and everything using every method available -
that means we keep re-probing found services, right? Should we instead
stop the probing loop, based on mechanism, as soon as *some* mechanism
finds *something*/*anything*? Otherwise we repeat ourselves(?), and as
more and more mechanisms come along, pmfind is going to get more and
more expensive...?
I can see this being a global option and a companion to the pending
timeout option. There are probably users who want any result and would
be satisfied with the first one (the qa tests themselves could benefit
from this) and others who want the full results. The also-pending
callback will be another way for users to consume the output as it is
discovered. Combining all of these will certainly yield a wide range of
ways to use the API and the tool.
With respect to repeating ourselves, each mechanism may indeed discover
some of the same services, but there could also be some disjointness.
The overall url collector filters out any duplicates..
Dave
Dave
|