Hi Nathan,
On Tue, May 27, 2014 at 01:36:46AM -0400, Nathan Scott wrote:
> Hi Michele,
>
> Two more thoughts :) Given this last topic I mentioned ...
Thanks for all your feedback, precious as usual. I've started
tackling some of your previous points and added the other
ones to the TODO.
> ----- Original Message -----
> > [...]
> > - More future work that might help (less distant though :) - there's
> > a current effort underway to make the Convenience Class python module
> > work and take on alot more of the effort that python client tools are
> > still having to do (as you've found here). Things like converting
> > counters to rates, improved caching (pmDesc, indoms/inst names, etc,
> > etc), things like that. ... pmAtomValue -> python type conversions
> > too, the sorts of things you needed to do in PcpArchive.get_values()
> > ... any things you've discovered in your hacking so far as "nice to
> > have" from such a module, please point 'em out (and feel free to help
> > scox & I out with hacking in that module too :) - this is "pcp.pmcc"
> > in the tree at src/python/pcp/pmcc.py).
> >
>
> - would it make sense to include the pcpstats code in the pcp tree &
> release it along with all the other tools? (as these API advances
> happen we could be immediately updating this code as well then). The
> license you've chosen is a direct match for PCPs, and I'm a big fan
> of driving API evolution from the needs of actual tools using the
> code ... so I'd be all for direct inclusion if you'd like to go that
> route.
Sure thing, works for me. Anything that helps PCP's adoption I'm happy
with ;) I fully agree with the API evolution thought. Give me a week or
two to clean up the code and then we can work on putting it into the
main tree.
> - "pcpstats" seems a fairly generic name, could I suggest "pcp2pdf"
> as a more specific, catchy handle?
Indeed, makes sense ;)
> - oh, 3rd & 4th points too, sorry - there's loads of archives to test
> with in the PCP tree below qa/src (you've started a tests/pcp-files
> directory with similar goals I see); also, there's a handy PMDA in
> PCP that might help your testing efforts; pmdasample has metrics of
> every conceivable flavour (types, units, semantics, lots of insts,
> fast-changing-insts, etc, etc).
Ack, I'll clean up the remaining most embarassing parts of the code,
and work on a branch that can be merged into pcp proper. I'll make sure
that I move the test suite to the qa folder using the existing archives.
You can then take a look and we adjust anything that needs fixing before
merging it.
cheers,
Michele
ps. I might take a bit longer as I have some work-related trips
coming up.
--
Michele Baldessari <michele@xxxxxxxxxx>
C2A5 9DA3 9961 4FFB E01B D0BC DDD4 DCCB 7515 5C6D
|