Hi Michele,
----- Original Message -----
> Hi all,
>
> on https://github.com/mbaldessari/pcp/tree/fix-python-pmunitsstr
> you can find a small fix for a segfault I stumbled upon while using
> the python bindings.
>
> Do let me know if this way of sending patches is ok ;)
>
Yep, no problem at all. I converted those test cases into automated
tests using the following recipe (see qa/README for chapter & verse):
$ cd qa
[look in qa/src for an archive with proc.nprocs -> bug_v2.0]
$ ./new
[insert cases here - qa/729 auto-created, add to "python" group]
$ sh 729
QA output created by 729
Exercising units string
729: line 42: 18190 Segmentation fault python $tmp.units
Exercising interval parsing
729: line 44: 18195 Segmentation fault python $tmp.parse
[install Michele's fixes here]
$ sh 729
QA output created by 729
Exercising units string
Completed safely
Exercising interval parsing
Completed safely
$ sh 729 > 729.out
$ git add 729 729.out group
[commit]
$ ./check -g python
[0%] 553 1s ...
[5%] 702 6s ...
[11%] 707 6s ...
[17%] 708 0s ...
[23%] 709 15s ...
[29%] 710 0s ...
[35%] 717 27s ...
[41%] 718 11s ...
[47%] 722 13s ...
[52%] 729
[58%] 737 0s ...
[64%] 739 1s ...
[70%] 741 0s ...
[76%] 742 1s ...
[82%] 743 0s ...
[88%] 979 1s ...
[94%] 991 1s ...
Passed all 17 tests
./qa/new just generates a template test case for you, its safe to
run anytime - doesn't commit anything or otherwise muck with your
tree, other than automatically inserting the new test number into
the qa/group file ready for committing later.
cheers.
--
Nathan
|