Changes committed to git://git.performancecopilot.org/pcp.git dev
qa/701 | 26 ++++++++++++
qa/701.out | 2
qa/722 | 4 -
qa/979 | 21 ++++++++++
qa/979.out | 2
qa/980 | 21 ++++++++++
qa/980.out | 2
qa/group | 3 +
qa/src/GNUlocaldefs | 2
qa/src/pmatop-log.0 |binary
qa/src/pmatop-log.index |binary
qa/src/pmatop-log.meta |binary
qa/src/test_pmcc.python | 19 ++++-----
src/pmlogsummary/pmlogcheck.c | 7 ++-
src/pmlogsummary/pmlogsummary.c | 2
src/python/pcp/pmcc.py | 82 +++++++++++++++++++++++-----------------
17 files changed, 145 insertions(+), 48 deletions(-)
commit f23b0aaebe92567a9d60e33ee897f037058a12b0
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon May 19 16:03:26 2014 +1000
Add QA tests for basic pmcc checkout in live and archive modes
Tests 979 and 980 are added to verify python script functionality
using the pmcc module. Renamed the pmatop test archive to not use
the test name (722) that it was created for, and then reuse that
archive as it has all the metrics used by the test_pmcc script.
commit 5a0d0d22038197f83eca6e9f665532c363cfc899
Author: Stan Cox <scox@xxxxxxxxxx>
Date: Mon May 19 15:40:13 2014 +1000
Initial series of fixes and comments for pmcc.py module
Changes that reach basic, advertised functional state for
the pmcc (convenience classes) python module. Updates to
the earlier test python code also.
commit 3d193685cffdf27b6ba964c03b35e274cceb1392
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon May 19 15:30:14 2014 +1000
Fix pmlogcheck bad memory access sigsegv on some logs
If an archive contains a metric which initially has an
error recorded for it (no value) but later on good data
arrives, and that metric is a singleton (PM_INDOM_NULL)
then pmlogcheck will fail to handle it correctly. This
is because no space to hold the previous value for any
fetch is allocated during the initial error-containing
sample, and subsequently an assumption is made that we
did allocate that space.
Metrics with instances were handled correctly all along,
this only affects single-valued metrics.
Test 701 is added to exercise the fix. An audit of the
existing QA archives found the ace_v2 archive contains
the problematic pattern, and without the fix produces:
701: line 21: Segmentation fault pmlogcheck src/ace_v2
This resolves Fedora BZ #1077432.
commit 80bbd7a2f8ed2e8a5aef9da63cd02d57041d9dd3
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon May 19 14:15:42 2014 +1000
When usage message requested do not check for archive in
pmlog{check,summary}
|