| To: | Nathan Scott <nathans@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [pcp] PCP Updates -- Remove inet-specific API Use in Favour of the libpcp I/O API |
| From: | Dave Brolley <brolley@xxxxxxxxxx> |
| Date: | Thu, 24 Apr 2014 22:16:41 -0400 |
| Cc: | PCP Mailing List <pcp@xxxxxxxxxxx> |
| Delivered-to: | pcp@xxxxxxxxxxx |
| In-reply-to: | <1204878828.10178271.1398311378294.JavaMail.zimbra@xxxxxxxxxx> |
| References: | <360594769.5718335.1381470346334.JavaMail.root@xxxxxxxxxx> <5357FA37.2070202@xxxxxxxxxx> <1204878828.10178271.1398311378294.JavaMail.zimbra@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/23/2014 11:49 PM, Nathan Scott wrote: Looking good Dave. I hit one regression over in test 589 - looks like telnet-probe is not quite right. Diff below, I've push the merge into my own dev branch on oss; its the same as yours with a pmdacisco merge conflict sorted out. The failure looks like a non-blocking I/O issue of some kind during connect(2). $ diff 589.out 589.out.bad 12,13c12,13 < exit status is 0 (should be 0) < exit status is 0 (should be 0) ---I just pushed these to the brolley/dev branch of pcpfans. You might want to double check my resoltion of the cisco pmda conflicts. The pmda.cisco group of qa tests ran ok for me.
Dave
commit 8e560e72809f988621631dbf26e38414469813bc
Merge: 2522e16 8da53d2
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Thu Apr 24 22:01:17 2014 -0400
Merge remote-tracking branch 'origin/dev' into brolley/dev
Conflicts:
src/pmdas/cisco/pmda.c
src/pmdas/cisco/probe.c
commit 2522e16f324ab130c0812c1f33110b252a8d0685
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Thu Apr 24 21:47:27 2014 -0400
Improve error handling for callers of __pmConnectTo().
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [pcp] PCP Updates -- Remove inet-specific API Use in Favour of the libpcp I/O API, Dave Brolley |
|---|---|
| Next by Date: | pcp updates - repair ABI breakage and QA, Ken McDonell |
| Previous by Thread: | Re: [pcp] PCP Updates -- Remove inet-specific API Use in Favour of the libpcp I/O API, Dave Brolley |
| Next by Thread: | PCP Updates: Compilation Error When Buiding on Ubuntu 14.04 (kernel: 3.13), Dave Brolley |
| Indexes: | [Date] [Thread] [Top] [All Lists] |