----- Original Message -----
> These commits, on the brolley/dev branch of pcpfans remove the use of
> inet-specific APIs (i.e. no ipv6) in favour of the libpcp I/O APIs (which do
> support IPv6, where available).
>
> The original message from Nathan which inspired this can be found below.
>
> Some __pm level functions which were previously static were moved to impl.h
> in order to accomplish this.
>
> A local qa run shows no regressions.
Looking good Dave. I hit one regression over in test 589 - looks like
telnet-probe is not quite right. Diff below, I've push the merge into
my own dev branch on oss; its the same as yours with a pmdacisco merge
conflict sorted out. The failure looks like a non-blocking I/O issue
of some kind during connect(2).
$ diff 589.out 589.out.bad
12,13c12,13
< exit status is 0 (should be 0)
< exit status is 0 (should be 0)
---
> exit status is 1 (should be 0)
> exit status is 1 (should be 0)
16c16
< connect: Connection refused
---
> connect: Operation now in progress
19c19
< connect: Connection refused
---
> connect: Operation now in progress
This test requires a remote host, but even without one you should be
able to reproduce it using localhost/22 (see 2nd part of 589) - lemme
know if you have no luck and I'll dig deeper.
cheers.
--
Nathan
|