| To: | "Frank Ch. Eigler" <fche@xxxxxxxxxx> |
|---|---|
| Subject: | Re: pmlogger -u questions |
| From: | Ken McDonell <kenj@xxxxxxxxxxxxxxxx> |
| Date: | Tue, 15 Apr 2014 08:46:09 +1000 |
| Cc: | Nathan Scott <nathans@xxxxxxxxxx>, pcp@xxxxxxxxxxx |
| Delivered-to: | pcp@xxxxxxxxxxx |
| In-reply-to: | <20140414212551.GK14108@xxxxxxxxxx> |
| References: | <01e901cf56df$4ce97de0$e6bc79a0$@internode.on.net> <1665962954.4723287.1397437104781.JavaMail.zimbra@xxxxxxxxxx> <534B4330.1060008@xxxxxxxxxxxxxxxx> <y0meh104nvl.fsf@xxxxxxxx> <534C4FF4.5000304@xxxxxxxxxxxxxxxx> <20140414212551.GK14108@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 15/04/14 07:25, Frank Ch. Eigler wrote: Hi - On Tue, Apr 15, 2014 at 07:15:32AM +1000, Ken McDonell wrote:[...] Can we agree that -u semantics and no stdio should be the default behaviour going forward? [...]That would make sense to me ... Having actually made the change now, I like this even more ... in the simplest implementation it is a one line change in __pmLogNewFile() to add
setvbuf(f, NULL, _IONBF, 0);
and then everyone who creates an archive (pmlogger, pmlogrewite,
pmlogextract, pmlogreduce, ...) gets unconditional unbuffered I/O.
To get the logical record semantics I need a little more hackery as the trailer 4 bytes is currently done in a separate fwrite(). And the metadata writes are all fragmented, so I may need to do something smarter there. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: pmlogger -u questions, Frank Ch. Eigler |
|---|---|
| Next by Date: | Re: [pcp] pmlogrewrite questions from the developer meeting, Ken McDonell |
| Previous by Thread: | Re: pmlogger -u questions, Frank Ch. Eigler |
| Next by Thread: | Re: pmlogger -u questions, Frank Ch. Eigler |
| Indexes: | [Date] [Thread] [Top] [All Lists] |