Re: [pcp] PCP Updates: Fix Bug #1035: PMCD Should Not Fail to Start if NSS Fails to Initialize

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Dave,

----- Original Message -----
> [...]
> Frank and I talked a bit more about this and he correctly noted that,
> with this change, __pmSecureServerSetup() no longer contains a code path
> which returns anything other than 0. He has suggested changing it to
> return 'void'. I believe that it is possible that someday, such an error
> path could once again exist (e.g. if we were to implement Frank's
> example of having a pmcd/pmproxy mode for which secure connections are
> required). In that case we would be removing the return code only to add
> it again later. Even though this is currently only used by pmcd and
> pmproxy, I think we should think twice about changing the API if we
> think it could change back in the future.
> 
> Thoughts?

I tend to agree with you Dave - lets leave it as is please.  There's no
harm in always returning zero at this stage, and the option remains there
when we need it down the track (needed it in the past, will probably need
it again someday - it could easily have to malloc something at some point
then we'd need to handle the error return again I guess).

cheers.

--
Nathan