pcp
[Top] [All Lists]

pcp updates: kenj+nathans merges, qa fixes

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: pcp updates: kenj+nathans merges, qa fixes
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 18 Mar 2014 21:00:39 -0400 (EDT)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1624132458.1745332.1395190766353.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: PMnDo4JCVhF3pUezxE3WVeBpBslhGA==
Thread-topic: pcp updates: kenj+nathans merges, qa fixes
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 build/GNUmakefile               |    1 
 build/rpm/pcp.spec.in           |   10 
 debian/libpcp3-dev.install      |    1 
 man/man3/pmgetcontexthostname.3 |   26 
 man/man3/pmgetoptions.3         |  323 +++++++++
 qa/.gitignore                   |    7 
 qa/054                          |    4 
 qa/075                          |   17 
 qa/075.out                      |  213 ++++++
 qa/075.out.2                    |  186 -----
 qa/075.out.3                    |  188 -----
 qa/075.out.4                    |  190 -----
 qa/075.out.6                    |  192 -----
 qa/075.out.7                    |  196 -----
 qa/145                          |   24 
 qa/145.out                      |   78 ++
 qa/145.out.1                    |   83 --
 qa/145.out.2                    |   78 --
 qa/207                          |    9 
 qa/207.out                      |   18 
 qa/259                          |   13 
 qa/259.out                      |   19 
 qa/282                          |    8 
 qa/293                          |    2 
 qa/293.out                      |    2 
 qa/294                          |   40 -
 qa/294.out                      | 1111 ++++++++++++++++++++++++++++++++
 qa/294.out.1                    | 1109 --------------------------------
 qa/294.out.2                    | 1109 --------------------------------
 qa/294.out.3                    | 1086 -------------------------------
 qa/294.out.4                    | 1086 -------------------------------
 qa/326                          |    4 
 qa/344                          |   14 
 qa/344.out                      |  884 +++++++++++++++++++++++++
 qa/344.out.1                    |  666 -------------------
 qa/344.out.2                    |  688 -------------------
 qa/344.out.3                    |  686 -------------------
 qa/417                          |   56 -
 qa/417.irix.1                   |  405 -----------
 qa/417.linux.1                  |  405 -----------
 qa/417.linux.2                  |  405 -----------
 qa/417.linux.3                  |  405 -----------
 qa/417.out                      |  405 +++++++++++
 qa/434.out                      |   59 -
 qa/464                          |    8 
 qa/464.out                      |   67 +
 qa/464.out.1                    |   69 -
 qa/464.out.2                    |   67 -
 qa/569.out                      |   72 +-
 qa/614                          |    5 
 qa/614.out                      |    2 
 qa/728                          |   90 ++
 qa/750                          |   25 
 qa/750.out                      |  203 +++++
 qa/750.out.1                    |  185 -----
 qa/750.out.2                    |  200 -----
 qa/750.out.3                    |  203 -----
 qa/786                          |   40 +
 qa/786.out                      |   84 ++
 qa/common.check                 |    4 
 qa/group                        |    2 
 qa/src/.gitignore               |    2 
 qa/src/GNUlocaldefs             |    9 
 qa/src/getcontexthost.c         |  121 +++
 qa/src/getoptions.c             |  252 +++++++
 src/include/pcp/impl.h          |   10 
 src/include/pcp/pmapi.h         |  183 ++++-
 src/libpcp/src/GNUmakefile      |    2 
 src/libpcp/src/check-statics    |    1 
 src/libpcp/src/context.c        |   36 -
 src/libpcp/src/exports          |   16 
 src/libpcp/src/getopt.c         | 1383 ++++++++++++++++++++++++++++++++++++++++
 src/libpcp/src/spec.c           |   49 +
 src/pmclient/pmclient.c         |  258 +------
 src/pminfo/pminfo.c             |  369 +++-------
 src/pmprobe/pmprobe.c           |  293 ++------
 src/pmstat/pmstat.c             |  920 ++++++++------------------
 src/pmstore/pmstore.c           |  131 +--
 src/pmval/pmval.c               |  783 ++++++++--------------
 src/python/GNUmakefile          |    2 
 80 files changed, 6585 insertions(+), 12072 deletions(-)

commit 5a42804538bb9b64707200c29142fc7ccd8efac9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Mar 19 11:54:31 2014 +1100

    A common pmGetOptions interface for reuse and long options
    
    Introduces pmGetOptions, pmFreeOptions and pmUsageMessage APIs.
    These abstract oft-repeated patterns in command line parsing of
    client tools into a single API.  Additionally, the ability for
    tools to use long options is introduced as is an ability to use
    environment variables for setting common options directly.  We
    can set flags to specify the slight variants on certain things
    that some tools have (e.g. pmstore requires posix-correctness,
    some tools allow multiple hosts/archives, others are one only,
    and so on).
    
    Some option processing requires a context to be established
    before it can be performed.  Timezones and time windows, in
    particular, but perhaps other similar things someday.  In
    order to share this code, introduce pmGetContextOptions to
    the common option parsing APIs encapsulating this, and also
    cleaning up some aspects that were problematic before (time
    window parsing in particular, is now delayed to a much more
    appropriate point).
    
    An initial batch of client tools have been converted to making
    use of the APIs, removing hundreds of lines of code while also
    making them able to use long options (in addition to the single
    character options they have always had): pmstat, pmval, pminfo,
    pmclient, pmprobe, and pmstore.
    
    Small bug found in the pmstat command, where it would not
    honour the TZ environment variable due to effectively being
    in -z mode by default (stray pmNewContextZone call).
    
    QA test qa/src/getoptions.c and wrappers (728, 757) have been
    added for exercising the new functionality.
    
    Other QA tidbits: for affected QA tests, begun removing back-
    compatibility output variants.  Some messages have changed in
    some tools, as we've now got consistent error messages for all
    tools with the same options.  Some diagnostics have slightly
    changed order too (e.g. order of the pmFetch for pmcd.timezone
    may differ sometimes); several tests were changed to deal with
    this anomoly.  Another class of test issues was in those tests
    containing usage messages of the standard tools like pminfo -
    they have been unconditional remade.

commit ca5907e5e55da8ba95de325050625eeb8174205a
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Mar 19 10:37:36 2014 +1100

    Remove hard-coded reference to /var/adm/pcplog
    
    The qa/common.check script contained an IRIX-ism where
    it was still using /var/adm/pcplog, instead of the env
    var parameterised paths.  This was harmless but causes
    complaints from SELinux in policy checking modes.
    
    Tackles one aspect of Red Hat bug: #1072785

commit 18808ea5fdfd9112eb3a76e8c780fa085d4e517c
Author: MiloÅ PrchlÃk <mprchlik@xxxxxxxxxx>
Date:   Wed Mar 19 10:35:19 2014 +1100

    Rework test qa/282 to preserve SELinux context on pmcd
    
    Instead of copying aside, and then back, the system pmcd
    binary (which loses any extended attributes, by default)
    move it instead (thus preserving attributes).
    
    Tackles one aspect of Red Hat bug: #1072785

commit d03e715be65bc76d854dac6c00094013e4f2b89d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Mon Mar 17 17:13:58 2014 +1100

    pcp.spec.in - ia64 and python-ctypes changes
    
    Don't use lib64 for SuSE ia64 builds.
    
    Fix conditional for python-ctypes so it only applies to RedHat
    builds.

commit bd1d4f76675dae9aaf285afb96d2a553a02d1d38
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Mon Mar 17 15:48:39 2014 +1100

    build/GNUmakefile - be a little more totalitarian
    
    When building after a build failure blow away the previous corpse
    unconditionally.

commit 7475319906606314716c9d24de4a64f8feb702bf
Merge: b2779ad b6fe37e
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Mon Mar 17 08:46:03 2014 +1100

    Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev
    
    Non-overlapping conflict around qa tests 786 & 798
    
    Conflicts:
        qa/group

commit b2779adc04ab9967de1a494d744f30f0c5c7e6e5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Mon Mar 17 08:36:41 2014 +1100

    debian packaging - add pmGetContextHostName_r to man page manifest

commit 2f6892051ba5b406b1b9e36c6e8061a165e76dc0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Mar 16 17:53:02 2014 +1100

    libpcp - fix bug in __pmUnparseHostSpec
    
    pmDupContext() was failing for local: and unix: contexts.
    
    Root cause was incorrect values being return in these cases from
    __pmUnparseHostSpec().

commit f5d5f2023eed147d7185cd971fd5d229fdb13d71
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Mar 16 17:52:10 2014 +1100

    libpcp - add pmGetContextHostName_r

commit bd87c92ebc98cc95583745dd459fc6c34ccbb0d8
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Mar 16 17:50:34 2014 +1100

    qa/786 (new) - exercise pmGetContextHostName and pmGetContextHostName_r

commit 08446e09a4a5960fcf24362e5754b1ae8ebcdae6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Mar 16 17:44:08 2014 +1100

    python makefile - avoid env pollution
    
    Take better control of the local $(ENV) so it is not inherited from
    environment ... this broke the build on one machine.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: kenj+nathans merges, qa fixes, Nathan Scott <=