On 03/06/2014 03:32 AM, Nathan Scott wrote:
Hi Dave,
----- Original Message -----
[...]
This code tries to make sure that pmlogger is running by attempting to
connect using pmlc. Without the updated access controls, pmlogger
correctly rejects each connection attempt and the loop logic does work
as intended, decrementing $delay toward zero. The problem is that $delay
gets set to 25100, and each connection attempt takes about 1 second. As
Hmm, that seems alot (the 1 sec to fail a local connection part). *shrug*
Yeah. That was actually about 1 second for each loop iteration. I'll
investigate further to find out for certain where in the loop the delay is.
* For this case where the response is "Unable to connect: ...
Connection refused", the loop should exit immediately.
That doesn't sound right - did you mean "Permission denied"? We expect
to get connection refused (i.e. pmlogger is not yet listening) for some
time, for pmlogger processes logging far-away hosts in particular.
Good point. The actual error we're getting is "Connection refused".
There is probably a bug lurking here.
At the end of the day, none of this is acceptable behaviour for someone
upgrading a perfectly working system of course. We can also expect that
some people will continue to use existing configuration files - we can't
assume any change there (via pmlogconf), it needs to Just Work (and it'd
be preferable to improve security for those folks with unchanged configs
too, but that may not be possible & that's fine). There are people who
generate or otherwise supply pmlogger config files of their own crafting
- e.g. predating pmlogconf - those environments need to continue working
after the upgrade.
Agreed, err I mean *nod*
Dave
|