pcp
[Top] [All Lists]

PCP Updates: AF_UNIX sockets for pmlogger/pmlc, review rework

To: pcp@xxxxxxxxxxx
Subject: PCP Updates: AF_UNIX sockets for pmlogger/pmlc, review rework
From: Dave Brolley <brolley@xxxxxxxxxx>
Date: Wed, 05 Mar 2014 11:56:10 -0500
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On the brolley/dev/branch of pcpfans ....

--------------------------------------------------------------------
commit 5046073d44836ff02af15630ba39e06cd4a3d0a5
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 16:55:16 2014 -0500

    Error messages now correctly refer to pmlogger, not pmcd.

commit 9349d8641aa681b493c616f43258860965e48e90
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 16:24:25 2014 -0500

    Fix socket fd leak in GetPorts() (pmlogger).

commit 3b2eb2e0fb19e48b4dcca7782bf656afa12966bd
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 16:18:10 2014 -0500

    Call __pmNoMem() in ConnectPMCD() (pmlc) when out of memory.

commit fdbc97d3903c33f96580808fcef8a77376db4dc5
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 16:12:43 2014 -0500

Rework the flow of logic in the NSPR implementation of __pmGetNameInfo().

commit b01572d581dea4adffd839d8e339656349e63b3d
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 15:51:09 2014 -0500

    Fix memory lead (ctxhost) in __pmLogFindPort()

commit e5b3075f4617597e22f5ba88fb0078e51b4c8fa4
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 15:43:05 2014 -0500

    Fix fd leak in connectLoggerLocal()

commit 707b499d8fd9867be47bfae2c0d2f2e2b226aa33
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 15:22:23 2014 -0500

Rename of __pmMkDir() to __pmMkPath() should have been to __pmMakePath().

    The actual name suggested in the code review.

commit fb5b05c1b1dabc4185263b87fd96f766621d2a62
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 15:04:11 2014 -0500

    Code formatting and typo fixes as recommended by code review.

    Items mentioned in the code review for AF_UNIX sockets for
    pmlogger/pmlc.

commit 9aabf24a17e71cff1c221a184d875b8f0ea0d76a
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Mar 4 14:32:16 2014 -0500

Change the API for __pmLogLocalSocketDefault() and __pmLogLocalSocketUser().

    - Buffers are no longer static within the function.
    - Buffers and size are now passed in by th caller.
    - No need for PM_LOCK anymore.
    - Update all callers.
    - Update check-statics

commit d2e87db1c006c98067e05fac25c354dec79923c3
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Mar 3 17:35:21 2014 -0500

    __pmHomedirFromID() now returns NULL on error.

    All Callers updated.

commit 138d204590757960879499918315e725aa4fb920
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Mar 3 17:31:25 2014 -0500

Rename __pmMkdir() to __pmMkPath() and add new exports to the PCP_3.2 section.

commit f3dba49cafd9da8a68d686b433bca3197c51f29e
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Mar 3 12:50:06 2014 -0500

For ordinary users, create the AF_UNIX pmlogger control socket in ~/.pcp/run/

    Created as ~/.pcp/run/pmlogger.<pid>.socket

<Prev in Thread] Current Thread [Next in Thread>
  • PCP Updates: AF_UNIX sockets for pmlogger/pmlc, review rework, Dave Brolley <=