Changes committed to git://oss.sgi.com/pcp/pcp.git dev
CHANGELOG | 30
build/rpm/fedora.spec | 11
build/rpm/pcp.spec.in | 9
debian/changelog | 2
man/man1/pmmgr.1 | 44
qa/.gitignore | 2
qa/115 | 4
qa/115.out | 1
qa/228 | 16
qa/321 | 1
qa/514 | 7
qa/514.out.3 | 2438 +++++++++++++++++++++++++++++++++++++++++++
qa/520 | 7
qa/520.out.3 | 597 ++++++++++
qa/523 | 17
qa/523.out | 14
qa/523.out.1 | 497 ++++++++
qa/523.out.2 | 499 ++++++++
qa/733 | 17
qa/733.out | 1
qa/733.out.1 | 239 ++++
qa/733.out.2 | 240 ++++
qa/815 | 32
qa/815.out | 12
qa/GNUmakefile | 2
qa/common.filter | 1
qa/group | 1
src/libpcp_pmda/src/tree.c | 55
src/pmie/src/fetch.sk | 9
src/pmie/src/meta | 4
src/pmie/src/pmie.c | 2
src/pmmgr/TODO | 12
src/pmmgr/config/GNUmakefile | 2
src/pmmgr/pmmgr.cxx | 412 ++++---
src/pmmgr/pmmgr.h | 1
src/pmmgr/rc_pmmgr | 2
src/pmwebapi/rc_pmwebd | 2
37 files changed, 5020 insertions(+), 222 deletions(-)
commit c3cc4a5d8d27a66f5515b5e18b1d4a883429fbc6
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Feb 18 14:22:36 2014 +1100
Updates to the changelog for upcoming release
commit 9059d67d68ed31272f4bf76d8868481185b0670a
Merge: fc724d8 c8c1a0c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Feb 18 13:50:59 2014 +1100
Merge branch 'dev' of git://oss.sgi.com/kenj/pcp into dev
commit fc724d844c845eb85f60627fd45f5e0161312d82
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Mon Feb 17 18:30:18 2014 -0500
pmmgr signal handling: don't need to propagate signals to process group any
more
The new wrap_system() does the job adequately.
commit 4449933b4d2c45ce0a21e330bfa5bca758bc02db
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Mon Feb 17 16:44:46 2014 -0500
pmmgr: improve responsivity to incoming signals
This is done by an open-coded wrapper that acts like system(3),
except it cooperates with the main process' signal handling scheme.
commit 70a59cacb6e572986d898b1838facfb1c6242b2d
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Sun Feb 16 11:54:50 2014 -0500
pmmgr signal-response improvements, part 1: respond to quit!=0 quicker
Add checks between timetaking operations for an early return/exit
in case of a pending interrupt (quit != 0).
commit 7cbb25fb1f406671f31d6e4990cf63d6cdff804a
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Sat Feb 15 18:35:03 2014 -0500
pmmgr: tweak pmlogrewrite operations to occur just before merges, only on
their inputs
commit bc8a0b6cfb115ab6141950c783cd7ab1fc00c231
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Sat Feb 15 16:23:03 2014 -0500
pmmgr TODO: add some
commit 7bde35210d8f1e6b9d847f99e42176d506032387
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Fri Feb 14 15:37:26 2014 -0500
pmmgr.1: note that -v generates stdout traffic, not stderr
commit 7135019376a30d82323e9612611df0ba4cd9e845
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Fri Feb 14 14:38:27 2014 -0500
pmmgr: add pmlogmerge-granular mode
This mode tweaks log management to optionally operate on a granular
basis, that is to merge only archives belonging to a recent past time
grain. Archives belonging to the current time grain are left alone
(for merging once, at the next one), and archives belonging to
long-previous time grains are left alone.
The overall effect can approximate the pmlogger_daily type of log
rotation, but time grains of any other size may be chosen via the
pmlogmerge control file's contents.
This mode is made default for new installations by the presence of a
pmlogmerge-granular control file.
Garbage collection is enhanced to catch even corrupt old archives,
based upon the pmlogmerge-retain control file.
commit 3d64385188560aa3a26cdcf99e1d61fb34f3d845
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Feb 18 13:13:18 2014 +1100
More work bullet-proofing the libpcp_pmda dynamic tree code
Deal with NULL calls coming into the API in several more places,
add recoverable error handling on hash rebuild calloc failure.
commit b66986f2b037803002fc470be12d05b41075a332
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Feb 18 11:19:48 2014 +1100
More testing of cases from MiloÅ and a final take on pcpqa user setup
Further combinations of existing system state (in terms of which dirs
already exist and which do not) uncovered further pcpqa account setup
issues. We now take the -M approach of not having useradd create our
homedir, just as we do for the pcp account, knowing installation will
be creating it for us (take that responsibility away from useradd).
Resolves Red Hat bug #1025688.
commit c8c1a0ce13dcf307314a5bfeb7bb9471154a3fda
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 16:18:33 2014 +1100
pmie - another day one bug, this time in count_* operators
The operand of the count_inst, count_host and count_sample operators
is a logical expression.
If the expression is set values (multiple instances for count_inst,
multiple hosts for count_host, etc), then the code did not check for
the tri-state value of UNKNOWN (or DUNNO internally), rather it added
the values assuming 0 for FALSE and 1 for TRUE ... DUNNO is 2 which
explains why the result was TWICE the size of the instance domain
if the expressions was undefined over and instance domain.
Part 2 of the bug Chandana de Silva discovered with this simple
pmie rule:
count_inst( match_inst "httpd" proc.psinfo.pid > 0) > 0
-> print "count %v";
that reported 6 most of the time, and sometimes reported 1400+
qa/815 now exercises something similar.
commit 82ab0b5504648e8cfd5fa42958af5cbbbf38875d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 16:12:35 2014 +1100
qa/733 - updated output after pmie bug fix
Seeing some more results with defined values after the first fetch.
commit ea2c1769470715e182e53c1dee5f09ac21dd39b4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 16:03:59 2014 +1100
qa/523 - updated output after pmie bug fix
Seeing some more results with defined values after the first fetch.
commit 7d41f28d952fe4f8a3cc8c4fc8afe11e12d15ba8
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 16:02:11 2014 +1100
qa/520 - updated output after pmie bug fix
Seeing some more results with defined values after the first fetch.
commit 10c792f36296a10ddcd2c13bbbb43af0df4bf8b1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 15:55:19 2014 +1100
qa/514 - updated output after pmie bug fix
Seeing some more results with defined values after the first fetch.
commit d1dfe14b083f9730f5cbd973a6764dabcb953d65
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 15:46:17 2014 +1100
pmie - day one bug in fetch logic
On the first fetch and the fetch after a dynamic instance domain
has changed membership, the values may have been incorrectly
marked as "not valid", preventing rules being evaluated correctly.
Part 1 of the bug Chandana de Silva discovered with this simple
pmie rule:
count_inst( match_inst "httpd" proc.psinfo.pid > 0) > 0
-> print "count %v";
that reported 6 most of the time, and sometimes reported 1400+
commit 1b883a0ca8bb91fe675973a2ed21760f7cb7b72a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 14:57:32 2014 +1100
qa/321 - dodge permission issue
"... warning cannot create stats file dir ..." message still appearing
after pmie change to quieten this because we're using pmie -v here.
Filter these lines out.
commit 6717436693b165a1a5401d3577e078a2a5aa0cc8
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 14:47:24 2014 +1100
pmie - quieten warning after tmp dir perms change
After recent changes to the mode and ownership of the
$PCP_VAR_DIR/tmp directory, the message "... warning cannot create
stats file dir ..." may be emitted each time pmie is run as a
user other than "pcp".
This happens a LOT in QA.
Since the message is only a warning, and the only side-effect is
that the pmie process is not visible in the instance domain of
the pmcd.pmie metrics (it is likely that no one but kenj cares!),
I've suppressed the message unless one of the pmie verbose flags
is set (-v, -V or -W).
commit 292d0374f4702db6225223b96bfb74fc9850e250
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 14:45:29 2014 +1100
qa/228 - dodge permission issue
"... warning cannot create stats file dir ..." message still appearing
after pmie change to quieten this because we're using pmie -v here.
Filter these lines out.
commit 017ec17ff3563047bb92806d69b0a9a1cfc38fbd
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 14:41:22 2014 +1100
qa/115 - non-determinism in pmie stop init script
The message "...: PMIE not running" may or may not be there ... add
filter and strip from expected output
commit 0f0ba77214193f6a415365e9ee2db2a53a6e8a6d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 14:39:11 2014 +1100
qa/815 [new] - tickle pmie bug
pmie bug in count_<foo> method when boolean expression is UNKNOWN
... thanks to Chandana de Silva for pointing out the example that
showed this.
commit 421b195fc4197eda0c5a93488f9e6c1681186cb4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Feb 17 14:35:49 2014 +1100
qa/common.filter - strip blank lines from pmie init script output
Recent changes to the pmie init scripts seem to have introduced the
possibility of blank lines being output ... make 'em go away so we
don't get unwanted QA failures.
Example blank line output ...
<---- HERE
/etc/init.d/pmie: Warning: Performance Co-Pilot Inference Engine (pmie) is
disabled.
To enable pmie, run the following as root:
update-rc.d -f pmie remove
update-rc.d pmie defaults 94 06
commit a3c1beeeca0280efb2a84303fce4603f7815771c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon Feb 17 13:54:57 2014 +1100
Do not include the generated qa_outfiles in the source tarball
This excluded qa_outfiles (generated list of QA test validated outputs)
from the source tarball shipped for each release. The problem that its
caused is that patching a tree with a new test results in the test .out
file being exluded from pcp-testsuite, since its not included with the
original list.
Resolves Red Hat bug #1064311.
commit 80dced72bc37bf9d00337e01386795cc4845a981
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon Feb 17 11:04:05 2014 +1100
Let pcpqa user homedir be created by useradd in rpm packaging
There's some evidence to suggest that useradd has refused to create
a homedir which the user cannot initially write to. Tackle this by
allowing useradd to create the final (basename) component.
Tackles Red Hat bug #1025688.
commit 4e3bc79318def74c5a2433461942465c6e6b94c5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Feb 16 16:33:19 2014 +1100
pmwebd and pmmgr ... terser start up messages
To be consistent with other PCP bits-n-bobs, we've been using terser
messages from the init scripts, so this commit changes
Performance Co-Pilot starting pmwebd (logfile is
/var/log/pcp/pmwebd/pmwebd.log) ...
and
Performance Co-Pilot starting pmmgr (logfile is
/var/log/pcp/pmmgr/pmmgr.log) ...
to become
Starting pmwebd ...
and
Starting pmmgr ...
commit 2e72eb8ea56067bfb8d82fa18cdd80cfdc636f70
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Feb 14 17:46:40 2014 +1100
Update changelog, general release prep for next week
|