Re: [pcp] Fwd: Official domain number for my Qpid PMDA project?

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Paul,

----- Original Message -----
> > ...
> > code review - I don't know anything about Qpid though.
> 
> Code review would be excellent.  There's still lots about PCP (and
> Qpid) that I haven't fully grok'd yet, so I'm sure there's plenty of
> opportunities for improvement.
> 

Wow, that is some neat code - I bet you have no loose papers on your
desk ;) - all tested, valgrind used, the class encapsulation looks
very nice in the end result PMDA, just generally neat.  Your C++-fu
far outshines mine!  :)

I'm appreciating all the metric help text - it all looks sensible &
the units and semantics used appear to be spot on.  Just good stuff
all round - again, well done!

Not sure if you came across dbpmda(1), but this option...

        options.add_options()
            ("no-pmda", bool_switch(), "run as a non-PMDA for development");

... made me wonder.  I use either/or in testing (PMDA options and/or
dbpmda), so having the option is still useful - just mentioning the
tool in case you'd not come across it yet.  Can be run as a regular
user, so can be simpler (and more targeted) than using pmcd itself.

> > Do you want a link
> > or two on http://oss.sgi.com/projects/pcp/source.html for those trees?
> 
> Yes, I would really like that :)
> 

Done.

cheers.

--
Nathan