pcp
[Top] [All Lists]

[Bug 1046] pmlogger heavy duplication in .meta output

To: pcp@xxxxxxxxxxx
Subject: [Bug 1046] pmlogger heavy duplication in .meta output
From: bugzilla-daemon@xxxxxxxxxxx
Date: Fri, 31 Jan 2014 21:06:06 +0000
Auto-submitted: auto-generated
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <bug-1046-835@xxxxxxxxxxxxxxxx/bugzilla/>
References: <bug-1046-835@xxxxxxxxxxxxxxxx/bugzilla/>

Comment # 2 on bug 1046 from
From having dipped into the code, we'd need to do a couple of things:

- change the definition of .meta indom records to mean updates
  rather than replacement

- change lipcp/src/logmeta.c addindom and/or searchindom to merge
  rather than replace new instlist/namelist entries

- change pmlogger/src/callback.c log_callback to handle the needindom=1
  case's numval^2 search with more finesse, that is to identify missing
  inst#'s individually, and emit a smaller incremental __pmLogPutInDom.

(We are assuming that instance strings never change.  That's not quite
correct: proc.* pid<->name strings should vary as processes exec(),
but the linux_proc pmda happens not to track that.)

The changing-the-definition part merits thought about how we envision
handling smallish changes to the archive format.  Must we bump
archive-major-version numbers?  Or can we tolerate old version
tools to slightly misbehave on newer data (as opposed to refusing to
process them outright)?


You are receiving this mail because:
  • You are on the CC list for the bug.
  • You are the assignee for the bug.
<Prev in Thread] Current Thread [Next in Thread>