Changes committed to git://github.com/pauljevans/pcp.git dev
qa/654 | 4 +-
qa/654.out | 2 +-
qa/655 | 17 +-
qa/655.out | 415 ++++++++++++++++++++++++++++++++---
qa/common.gfs2 | 8 +-
src/pmdas/gfs2/GNUmakefile | 6 +-
src/pmdas/gfs2/README | 4 +-
src/pmdas/gfs2/control.c | 76 ++++---
src/pmdas/gfs2/control.h | 23 +-
src/pmdas/gfs2/ftrace.c | 507
+++++++++++++++++++++++++++++++++++++++----
src/pmdas/gfs2/ftrace.h | 117 +++++++++-
src/pmdas/gfs2/glocks.c | 2 +
src/pmdas/gfs2/glstats.c | 2 +-
src/pmdas/gfs2/help | 380 +++++++++++++++++++++++++++++++-
src/pmdas/gfs2/lock_time.c | 220 -------------------
src/pmdas/gfs2/lock_time.h | 68 ------
src/pmdas/gfs2/pmda.c | 450 +++++++++++++++++++++++++++++++++++---
src/pmdas/gfs2/pmdagfs2.h | 18 +-
src/pmdas/gfs2/pmns | 209 ++++++++++++++++--
src/pmdas/gfs2/sbstats.c | 2 +
src/pmdas/gfs2/worst_glock.c | 267 +++++++++++++++++++++++
src/pmdas/gfs2/worst_glock.h | 69 ++++++
22 files changed, 2394 insertions(+), 472 deletions(-)
commit d26b227ad2382a75f69d154124611ed23259e9a5
Author: Paul Evans <pevans@xxxxxxxxxx>
Date: Sun Jan 12 16:50:03 2014 +0000
pmdagfs2: Add complete set of GFS2 tracepoint metrics
Added the complete list of GFS2 tracepoints as found at: /sys/kernel/
debug/tracing/events/gfs2/ 82 new metrics have been added along with
14 new control metrics (96 total new metrics).
The metrics for the following GFS2 tracepoints have been added:
- gfs2_glock_state_change
- gfs2_glock_put
- gfs2_demote_rq
- gfs2_promote
- gfs2_glock_queue
- gfs2_glock_lock_time
- gfs2_pin
- gfs2_log_flush
- gfs2_log_blocks
- gfs2_ail_flush
- gfs2_block_alloc
- gfs2_bmap
- gfs2_rs
The glock_lock_time metric has been renamed to worst_glock as this
more closely represents the stats that the metric provides (and so
there are not two metrics with similar names). The new tracepoint
metrics are handled in the ftrace.* files and the newly renamed
worst_glock.* separately handles the worst_glock metrics.
With these changes there has been slight tweaks to the update the
readability of some comments and the removal of some unneeded
includes. Help, QA (654, 655 and common.gfs2)and the Readme have all
been updated to reflect the changes in number of metrics and the name
change for the worst_glock metric.
QA tests and Covscan has also been run upon the code changes.
Let me know if there are any issues and as always any feeback is welcome :).
Cheers,
Paul
|