pcp
[Top] [All Lists]

pcp updates: pmmgr, pmfind, coverity

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: pcp updates: pmmgr, pmfind, coverity
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 8 Jan 2014 01:31:33 -0500 (EST)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <363329545.45855712.1389162572010.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: C5iyCu2gecdmr/du8ugKegP3VbyN7Q==
Thread-topic: pcp updates: pmmgr, pmfind, coverity
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 INSTALL                                         |    5 
 aclocal.m4                                      |   62 
 build/rpm/GNUmakefile                           |    1 
 build/rpm/pcp.spec.in                           |    5 
 configure                                       |  339 ++++
 configure.in                                    |   18 
 man/man1/GNUmakefile                            |    2 
 man/man1/pmmgr.1                                |  338 +++-
 qa/src/interp_bug.c                             |    8 
 qa/src/interp_bug2.c                            |    9 
 qa/src/ipc.c                                    |   27 
 qa/src/multithread5.c                           |   25 
 qa/src/multithread6.c                           |   23 
 qa/src/multithread7.c                           |   29 
 qa/src/multithread8.c                           |   23 
 qa/src/multithread9.c                           |   23 
 qa/src/pdu-server.c                             |   20 
 qa/src/pducrash.c                               |  425 ++---
 qa/src/pmcdgone.c                               |    6 
 qa/src/pmdashutdown.c                           |    2 
 qa/src/proc_test.c                              |   18 
 qa/src/torture_pmns.c                           |    2 
 src/GNUmakefile                                 |    4 
 src/dbpmda/src/dso.c                            |   10 
 src/dbpmda/src/pmda.c                           |    2 
 src/include/builddefs.in                        |   13 
 src/include/buildrules                          |    9 
 src/include/pcp.conf.in                         |    4 
 src/include/pcp/impl.h                          |   36 
 src/include/pcp/platform_header.h               |  675 ++++++++
 src/include/pcp/pmapi.h                         |    7 
 src/libpcp/src/GNUmakefile                      |    2 
 src/libpcp/src/access.c                         |    4 
 src/libpcp/src/auxconnect.c                     |   37 
 src/libpcp/src/auxserver.c                      |   72 
 src/libpcp/src/avahi.c                          |  410 ++++-
 src/libpcp/src/avahi.h                          |   12 
 src/libpcp/src/check-statics                    |    3 
 src/libpcp/src/context.c                        |    4 
 src/libpcp/src/discovery.c                      |  314 +++
 src/libpcp/src/exports                          |    5 
 src/libpcp/src/internal.h                       |   13 
 src/libpcp/src/logmeta.c                        |    2 
 src/libpcp/src/pmns.c                           |   14 
 src/libpcp/src/secureconnect.c                  |   39 
 src/libpcp/src/spec.c                           |   35 
 src/libpcp/src/util.c                           |   84 +
 src/libpcp_fault/src/GNUmakefile                |    2 
 src/pmcd/src/dopdus.c                           |    6 
 src/pmcd/src/dostore.c                          |    2 
 src/pmcd/src/pmcd.c                             |    2 
 src/pmdas/apache/apache.c                       |    3 
 src/pmdas/linux/interrupts.c                    |    4 
 src/pmdas/linux/proc_net_dev.c                  |   12 
 src/pmdas/linux/proc_scsi.c                     |    4 
 src/pmdas/linux_proc/ksym.c                     |   14 
 src/pmdas/mounts/mounts.c                       |    4 
 src/pmdas/rpm/rpm.c                             |    2 
 src/pmdas/systemd/systemd.c                     |    4 
 src/pmdas/trace/src/pmda.c                      |    5 
 src/pmdas/weblog/check_match.c                  |    2 
 src/pmfind/.gitignore                           |    3 
 src/pmfind/GNUmakefile                          |   31 
 src/pmfind/pmfind                               |binary
 src/pmfind/pmfind.c                             |  114 +
 src/pmie/src/pmie.c                             |   18 
 src/pminfo/pminfo.c                             |   46 
 src/pmlogger/pmlogger_daily.sh                  |    2 
 src/pmlogrewrite/pmlogrewrite.c                 |    2 
 src/pmlogsummary/pmlogsummary.c                 |    4 
 src/pmmgr/.gitignore                            |    1 
 src/pmmgr/GNUmakefile                           |  140 +
 src/pmmgr/TODO                                  |   25 
 src/pmmgr/config/GNUmakefile                    |   62 
 src/pmmgr/config/README                         |   15 
 src/pmmgr/config/hostid-metrics.default         |    2 
 src/pmmgr/config/log-directory.default          |    2 
 src/pmmgr/config/pmlogmerge-retain.default      |    2 
 src/pmmgr/config/pmlogmerge.default             |    2 
 src/pmmgr/config/target-discover.default        |    2 
 src/pmmgr/config/target-discovery.avahi         |    2 
 src/pmmgr/config/target-discovery.default       |    2 
 src/pmmgr/config/target-discovery.example-avahi |    1 
 src/pmmgr/config/target-host.default            |    2 
 src/pmmgr/pmmgr.cxx                             | 1317 ++++++++++++++--
 src/pmmgr/pmmgr.h                               |  159 +
 src/pmmgr/pmmgr.options                         |   32 
 src/pmmgr/rc_pmmgr                              |  298 +++
 src/pmmgr/src/.gitignore                        |    2 
 src/pmmgr/src/GNUmakefile                       |   78 
 src/pmmgr/src/pmmgr.cxx                         | 1924 ++++++++++++------------
 src/pmmgr/src/pmmgr.h                           |  300 +--
 src/pmval/pmval.c                               |    9 
 93 files changed, 5834 insertions(+), 2051 deletions(-)

commit 9ba94e34a669269b923799cfba6cd12363d78be0
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 17:23:47 2014 +1100

    Remove a duplicate definition of __pmServerPresence

commit e5067e1d6aea7a6b7fe032e0eaa1527774a06c67
Merge: a6ac0c8 8b7d071
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:38:58 2014 +1100

    Merge branch 'fche/dev' of ../pcpfans into fche/dev

commit a6ac0c85650bae64cb46fa0da5d2c8dca65987fd
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:37:41 2014 +1100

    covscan: additional initialisation checks for libpcp code, odd corner cases

commit 00a440caca5ec4cc45ace3e5f914e7a8ff3b67f5
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:36:38 2014 +1100

    covscan: add code to handle a fgets failure

commit 2d22d21252c2e24df695fb39d1f4957da02d9dce
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:34:54 2014 +1100

    covscan: fix very-hard-to-trip memleak in context creation

commit 328b1319ae085f640958e9dfab6cac79387b2611
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:33:09 2014 +1100

    covscan: minor source cleanup in qa test code

commit e55e0cedb53ae2bf88ac94fffa7d754a258f68a6
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:18:48 2014 +1100

    covscan: fix small error path memleak in libpcp access code

commit 300e4497fc84e9b4895d58aeb719a79aa5d7cd52
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:17:59 2014 +1100

    covscan: fix minor uninitd variables in dbpmda

commit 474dead15e7534dde0f8e0154774551a66df3af0
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:17:23 2014 +1100

    covscan: fix error message reporting buglet in pmlogsummary

commit c5a64fb5feb95c0c8a928cf3d8f8c475d6c9f9fc
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:16:54 2014 +1100

    covscan: fix minor uninitd variables in misc client tool

commit e268e4cf157c4033c95125be607917186d7215c7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:15:18 2014 +1100

    covscan: fix minor uninitd variables and null checks in pmdas

commit 2569e605b69fc065108bd452223123be6e09048b
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:14:09 2014 +1100

    covscan: fix couple of uninitd variable on pmcd err paths

commit 7ed7b8c806995489ddb70b528b49b8c4db4a249e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 15:10:53 2014 +1100

    covscan: fix uninitd variable in pmdarpm

commit 23678c4c4ac7f8fad847f4149d9166e4430210f1
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 13:06:20 2014 +1100

    covscan: fix harmless but wrong sizeof type to malloc in qa code

commit 3abd9229df3a61dedccf37bf433faea72147ad11
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 13:05:40 2014 +1100

    covscan: refactor proc_test and torture_pmns a bit for static checks

commit 6395f401152ae847bd73646d98ecf0b599d9641c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 12:50:17 2014 +1100

    covscan: fix memleaks in pducrash test source

commit 2fe5b5853ffc25418aa9cf73eee13507fbc303e8
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 12:46:09 2014 +1100

    covscan: refactor pducrash test source for static checking

commit 8063f305e05c547775b35682c11b43d060c87f0e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 12:05:27 2014 +1100

    covscan: fix memleaks in qa pdu-server code

commit e058fb78d392f7a107e1327aa2f01f631b74da3d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 11:56:55 2014 +1100

    covscan: fix multithread tests fopen/fclose use

commit b05e406a7722f143cb862f2555c0e60bb1120159
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 10:56:40 2014 +1100

    covscan: refactor qa ipc test to remove static scan confusion

commit 18c5e7027f85eb04c965f4af0ea4ae3b2a2883a4
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 10:45:31 2014 +1100

    covscan: remove useless result null checks in interp tests

commit 01d3a430201deea4f07edf847c55c005203aed78
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Jan 8 10:44:52 2014 +1100

    covscan: fix qa pmdashutdown use of uninitd dispatch var

commit 8b7d07195e25c9af250f963401b089c5ab6ccdae
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Jan 6 18:52:30 2014 -0500

    resolve merge conflict over __pmSockAddrGetPort
    
    kenj and brolley independently added these functions.  Resolve
    merge conflict in favour of ... coin toss ... brolley.

commit 45f978b7377c6bb7384e11385bdc10f0e506eb34
Merge: 99c3bc0 4d7b85b
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Jan 6 18:42:00 2014 -0500

    Merge remote-tracking branch 'pcp/dev' into fche/dev
    
    * pcp/dev: (26 commits)
      Fix the configure check for RHEL5 rpmlib
      Fix typo on pmlogextract man page synopsis
      Remove a no-longer-used qa out file for qa/575
      Man pages spelling fixes
      Update git ignore file for libpcp_fault builds
      linux pmda: plug memory leak in /proc/interrupts parsing
      libpcp - tweak diags in __pmConnect
      libpcp - *connect.c - diagnostic cleanup
      libpcp - add __pmSockAddrGetPort()
      pmie and pmproxy rc script tweak
      qa/003 - network.icmpmsg.* metrics sometimes unavailable
      qa/chk.setup - allow host on the command line
      man page rework for some NAME entries
      INSTALL - add notes for creating user pcp before make from source
      pmpost - one more bizarre name collision fixup
      pmie - temp file directory creation change
      pmpost - bizare name collision
      qa/282 - be more careful about mode and ownership of control files
      qa/994 - update driver data
      debian/pcp.postinst.tail - chown/chmod change for $PCP_LOG_DIR
      ...
    
    Conflicts:
        INSTALL
        src/include/pcp/impl.h

commit 99c3bc0607756fdfa7f150817f4ca7483fb4c7da
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Jan 6 15:51:23 2014 -0500

    pmmgr: correct zombie handling for dead hostids & subdir gc string matching

commit 817a1207997bf2ed12e4a2d52cfc539322ae9231
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 21:05:02 2014 -0500

    /etc/pcp/pmmgr: make dir & contents root- instead of pcp-owned

commit 1b1fe9f7c097d6d378bda1a9f81baab7966f9308
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 20:53:28 2014 -0500

    pmmgr: new option for garbage-collecting ancient hostid data

commit 517747212c6c650b946c86a284056f86f0f0ed89
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 19:53:37 2014 -0500

    pmmgr pcp.spec.in: mark /etc/pcp/pmmgr files %config

commit 1b26541664cb8f209cd225da71ac531c8a2e919f
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 18:52:11 2014 -0500

    pmmgr: check & overlook broken archives during pmlogmerge phase

commit d5e78ff08601d77e2ac69c3e436b8adf4ce0b730
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 18:00:57 2014 -0500

    pmmgr: for make-install, recurse into config/ subdirectory

commit 91018d51976ceefc29ac93e0ab700367e5aa5e2c
Merge: e400a72 e71374d
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 15:12:44 2014 -0500

    Merge remote-tracking branch 'origin/fche/dev' into fche/dev
    
    * origin/fche/dev:
      INSTALL: note need to create pcp/pcpqa userids if building straight from 
source
      pmlogger_daily.sh: tolerate case where no *.meta files exist for log 
merging
      pmda systemd: add sd_journal_process() to avoid inotify()-driven spinning

commit e400a72f406de35a8e5f694852269607f539cc51
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Thu Dec 19 13:42:08 2013 -0500

    Include the hostname in avahi service names.
    
    - Reduces service name collisions with other pmcds on the network.

commit 60767c51b61bd29461762f4303bf8b31cc2ffc2e
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 15:04:27 2014 -0500

    pmmgr: add pmlogmerge option to /etc/pcp/pmmgr/config defaults

commit ec49e95a5a9bec9bfad3d19e4ae2c3b4ce5a0a53
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 15:03:51 2014 -0500

    pmmgr: add some more TODOs

commit 3e3c4cee4007f1b2741afdabab52c4253178e94e
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 15:03:30 2014 -0500

    rc_pmmgr: include pmmgr.options support

commit 75b692c683200694ed532a89c1f63d222cfa6b74
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Jan 5 15:00:19 2014 -0500

    pmmgr.1: use .B for pcp commands rather than .I

commit e71374d017d2c6de72c1f8bce468d87fc8626e04
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Wed Dec 25 07:52:54 2013 -0500

    INSTALL: note need to create pcp/pcpqa userids if building straight from 
source

commit 1cd2e997e3ffb2ac0533449b76f12f020ea16161
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Tue Dec 24 07:46:22 2013 -0500

    pmlogger_daily.sh: tolerate case where no *.meta files exist for log merging

commit e626ec91e3ede0bf9ce27c594b5cbc522f6430f1
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Dec 19 14:35:27 2013 -0500

    pmda systemd: add sd_journal_process() to avoid inotify()-driven spinning
    
    As per systemd-journal API docs, if we use the systemd fd's for
    select() event-listening, we must call sd_journal_process(), so any
    content on those fd's is actually read.  Otherwise, we get a select()
    returning immediately, but systemd_refresh() consuming none of the
    inotify data, calling select again and again ad spinfinitum.

commit 480ad48bfde1bffcd093b78e751ac5320cf7d5af
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Wed Dec 18 14:37:04 2013 -0500

    pmmgr: make cppcheck(1) happier with little style tweaks

commit b6987a62521f90d6b4f801fba7f804f2c1c8e1db
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Tue Dec 17 18:02:11 2013 -0500

    pmmgr: respond quicker to sudden death of inferior daemons

commit dc45c7c57b6a042e2b6496e090dbdf499dd9e355
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 16 19:18:06 2013 -0500

    pmmgr: parallelize daemon configuration/startup
    
    The logger/pmie daemon-command-line generator functions do a ton of
    work outside the process, invoking pm*conf etc., in sequence.  Instead
    of invoking them serially, do each daemon X host in a separate
    pthread.  To keep the model/logic trivially simple, we do a massive
    fork / join around the daemon polls only, which means that a single
    long-lasting daemon X host startup can delay everything else.  But
    this is unlikely (?).

commit 2d1ddd75a9c81b98a6d1f521bd3708eaefaa6dd8
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 16 16:05:28 2013 -0500

    pmmgr: sort hostid-metric multi-instance values

commit 424ee764f2fae5c00f0e25ec69359d74ff517071
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 16 15:17:11 2013 -0500

    pmmgr build: make conditional via autoconf & build-me GNUmakefile idioms

commit 693241b35239fd75e82eb687c0b16212d0b29fb5
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 16 11:54:14 2013 -0500

    pmmgr config/ directory: drop all .default files
    
    The compiled-in defaults are mentioned in the man page already,
    and were confusing.

commit 6f386c30a83fabfe0e568741ee4a2a6dd1804f58
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Fri Dec 13 20:36:01 2013 -0500

    linux pmda: plug memory leak in /proc/interrupts parsing
    
    Previous code in src/pmdas/linux/interrupts.c accidentally forgot that
    it had already parsed the structure of /proc/interrupts into the
    interrupt_lines/interrupt_other realloc variables by resetting the
    lines_count/other_count variables every refresh.  That caused an
    endless re-allocation growth.  Hey, teacher, leave those _counts alone!
    
    Reported-By: Mahmoud Hanafi <mahmoud.hanafi@xxxxxxxx>

commit 34c9afab991ee41cb82367b85a6811cbeed9c21c
Merge: ec499b2 25bfc1e
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Fri Dec 13 11:09:10 2013 -0500

    Merge remote-tracking branch 'pcp/dev' into fche/dev
    
    * pcp/dev:
      Fix a typo in the pmwebd rc script
      libpcp __pmNotifyErr: correct va_list usage
      Update development branch version info for work-in-progress commits
      The Mac OS X ld has a different symbol version file format to GNU ld, 
disable
      Travel the Linux path for Mac OS X dtrace static probe support
      Update strings in Mac OS X installer for community release
      Resolve issue in test qa/528 with tmpdir leftovers
      Resolve deb bug #729857 using dpkg-maintscript-helper(1)
      Limit the number of collision resolution attempts for Avahi services.

commit ec499b22ba117350e87ed1bd3b656f97e0b5b2fd
Merge: 6e7af04 74d8fc3
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Fri Dec 13 11:08:38 2013 -0500

    Merge remote-tracking branch 'origin/brolley/dev' into fche/dev
    
    * origin/brolley/dev: (48 commits)
      Limit the number of collision resolution attempts for Avahi services.
      Add expected output for test 783
      libpcp_fault/GNUmakefile - small typo fix from previous commit
      qa/660 - fix IPv6 localhost name discovery, add $seq.full tracing
      Update version/changelogs in preparation for a bugfix release
      Different tack toward valgrind testing of pmdarpm, using -C option now
      Add a missing header dependency in pmdarpm makefile
      linux_proc pmda: correct stack blowage during ioctl() for network 
interfaces
      Simplify and add to the QA valgrind suppressions file
      Correct bitfield values in PMDA cache code
      Testing suggests the rpm HEADERGET_MINMEM flag is safe for us
      Fix semantics for rpm.datasize and remove dup metrictab entry
      Move the pmdarpm fetch callback locking to the correct spot
      pmie_daily - avoid cron mail chatter
      qa/536 - /bin/sh is not bash
      libpcp_fault - make it work again
      qa/529 - rework stdin case
      Initial version of valgrind test for pmdarpm
      Small cleanup to rpm test qa/750 and common code
      qa/575 - don't remove $PCP_TMP_DIR/pmie
      ...

commit 6e7af04e9d1fd230fae60e444817358fde6984f3
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Dec 12 16:32:19 2013 -0500

    pmmgr: tweak rc options to match available pmmgr parameters

commit aae2c5b8478a02fa33f0d2a1b667017ffaf72685
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Dec 12 16:28:59 2013 -0500

    pmmgr: standardize cout/cerr log messages

commit dddc393412ea7c57c340e7ad6693f5ef12aa9b16
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Dec 12 15:06:53 2013 -0500

    libpcp __pmNotifyErr: correct va_list usage
    
    In the do_syslog case, a va_list parameter was being passed to
    snprintf, and never reset for subsequent use by vpmprintf().
    Use the correct varargs operations.

commit 1c7d1ad9be52c4a3e06be6f149dea7207bca17c4
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Dec 12 13:28:25 2013 -0500

    pmmgr: interpret configured log-directory relative to cfg-directory if 
necessary

commit 3d36ae79762b0a46fd26728f42c3ae01a7ce10a2
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Dec 12 13:27:58 2013 -0500

    pmmgr: add sample config ditty for avahi-based pmcd autodiscovery

commit a78ff4713fc0064703f2a94d6f40950a81710d5b
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Dec 12 13:19:14 2013 -0500

    pmmgr: move pmmgr/src/* into pmmgr/*
    
    The code base is small enough.

commit 7f51c662c2ab392c7a4c45531075b3f30e19cfca
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Thu Dec 12 12:15:06 2013 -0500

    pmmgr: add pmmgr.options, cargo-culted from pmwebd

commit 74d8fc37195df0e9a66da95656445b5799b70f07
Merge: 8301d0d b1c3a47
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Wed Dec 11 12:27:12 2013 -0500

    Merge remote-tracking branch 'origin/dev' into brolley/dev
    
    Conflicts:
        src/libpcp_fault/src/GNUmakefile

commit 8301d0d2ee1a83302f66701847009f0dfa5a02e8
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Wed Dec 11 12:23:56 2013 -0500

    Limit the number of collision resolution attempts for Avahi services.

commit 00d6cf7797b8c328aae536f88707a9c2f4d88fc7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 22:01:55 2013 -0500

    linux_proc pmda: correct stack blowage during ioctl() for network interfaces
    
    We finally isolated the cause of the peculiar stack-segment
    supergrowth seen occasionally for pmcd on linux, wherein
    multi-gigabyte stacks sometimes briefly appeared on x86-64 hosts.
    Some analysis with systemtap [1] helped pinpoint the linux_proc
    network ioctl()s as causing the problem.  The problem appears to be
    the corruption of the ioctl-argument ifr->ecmd pointer between
    consecutive ioctl()s.  This is now corrected by reinitializing
    before each ioctl().
    
    [1] # stap -e '
    probe kernel.function("acct_stack_growth") {
       if (execname()=="pmcd") {
          println (pn(), " ", $$parms)
          print_backtrace()
          print_ubacktrace()
       }
    }' -d /usr/libexec/pcp/bin/pmcd -d /var/lib/pcp/pmdas/linux/pmda_linux.so 
--ldd
    
    Which reported, inter alia,
    
    kernel.function("acct_stack_growth@mm/mmap.c:2035") grow=0x17d92 
size=0x17db4000 vma=0xffff88009d80b000
     0xffffffff8116c560 : expand_downwards+0xb0/0x240 [kernel]
     0xffffffff8116c714 : expand_stack+0x24/0x40 [kernel]
     0xffffffff8165207f : __do_page_fault+0x43f/0x510 [kernel]
     0xffffffff8165215e : do_page_fault+0xe/0x10 [kernel]
     0xffffffff8164e6d8 : page_fault+0x28/0x30 [kernel]
     0xffffffff81306ae5 : copy_user_generic_string+0x35/0x40 [kernel]
     0xffff88009d8bfe18
     0xffffffff812a72ec : sidtab_context_to_sid+0x30c/0x480 [kernel] (inexact)
     0xffffffff8154a399 : dev_get_by_name_rcu+0x69/0x90 [kernel] (inexact)
     0xffffffff8155f56b : dev_ioctl+0x1ab/0x560 [kernel] (inexact)
     0xffffffff81634d02 : netlbl_domhsh_hash+0x12/0x50 [kernel] (inexact)
     0xffffffff8129e7fc : selinux_file_alloc_security+0x3c/0x60 [kernel] 
(inexact)
     0xffffffff81531195 : sock_do_ioctl+0x45/0x50 [kernel] (inexact)
     0xffffffff815315e0 : sock_ioctl+0x1f0/0x2c0 [kernel] (inexact)
     0xffffffff811b9fdd : do_vfs_ioctl+0x2dd/0x4b0 [kernel] (inexact)
     0xffffffffa0ecba01 [stap_ee080e3c411678e5f019bf218d63791_23997] (inexact)
     0xffffffff811ba231 : SyS_ioctl+0x81/0xa0 [kernel] (inexact)
     0xffffffff81656aa7 : tracesys+0xdd/0xe2 [kernel] (inexact)
     0x2ba833548eb7 : ioctl+0x7/0x30 [/usr/lib64/libc-2.17.so]
     0x2ba8368cfee6 : refresh_proc_net_dev+0x256/0x590 
[/var/lib/pcp/pmdas/linux/pmda_linux.so]
     0x2ba8368c9e2b : linux_refresh+0x39b/0x450 
[/var/lib/pcp/pmdas/linux/pmda_linux.so]
     0x2ba8368c9fe8 : linux_fetch+0x108/0x170 
[/var/lib/pcp/pmdas/linux/pmda_linux.so]
     0x2ba832bbcdf5 : DoFetch+0x585/0x1460 [/usr/libexec/pcp/bin/pmcd]
     0x2ba832bb6a8b : HandleClientInput+0x28b/0x510 [/usr/libexec/pcp/bin/pmcd]
     0x2ba832bb6f03 : ClientLoop+0x1f3/0x6b0 [/usr/libexec/pcp/bin/pmcd]
     0x2ba832bb5a2b : main+0x5db/0x7c0 [/usr/libexec/pcp/bin/pmcd]
     0x2ba83347db45 : __libc_start_main+0xf5/0x1c0 [/usr/lib64/libc-2.17.so]
     0x2ba832bb5c39 : _start+0x29/0x30 [/usr/libexec/pcp/bin/pmcd]

commit 4f371507a86640b6a43f8468b9a8b791ccd52b2d
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Tue Dec 10 16:49:15 2013 -0500

    pmmgr: add sh_quote() quoting for sh -c arguments as they're being 
constructed

commit 47cc22debe39b172d3407288dac93aec4dd59666
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 9 18:35:57 2013 -0500

    pmmgr docs: fix typo in config/target-discovery

commit ca8dd672b12a01fefd6a05f177aac40e94a50886
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 9 18:17:06 2013 -0500

    pmmgr: add rc file

commit e07d949fbd979b836a77ce7098add1363215d703
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 9 17:10:37 2013 -0500

    pmmgr: avahi adaptation

commit 433e94411f2220b0ec559f31531e6b9a7d28f391
Merge: ed556d4 74cce0f
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 9 16:56:53 2013 -0500

    Merge remote-tracking branch 'origin/brolley/dev' into fche/dev
    
    * origin/brolley/dev:
      Remove the 'numUrls' parameter from pmDiscoverServices().
      Rename SERVER_SERVICE_SPEC to PM_SERVER_SERVICE_SPEC and move it from 
impl.h to pmapi.h.

commit ed556d4eaa35fd5fa61c39eb69d7027b6d951227
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 9 16:56:34 2013 -0500

    pmmgr: adopt pmDiscoverServices api

commit 74cce0f0aed73a3bdf20a16c2783916f08376d32
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Dec 9 16:45:41 2013 -0500

    Remove the 'numUrls' parameter from pmDiscoverServices().
    
    Each call will allocate a new list of results.

commit 2cb397485cf4c204aceb4ff54e298f20f3b171c6
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Dec 9 16:10:01 2013 -0500

    Rename SERVER_SERVICE_SPEC to PM_SERVER_SERVICE_SPEC
    and move it from impl.h to pmapi.h.

commit f3b53b78c749751eb311d5e995c5a747e5b1cc1d
Merge: 8824714 e8551fa
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 9 15:39:47 2013 -0500

    Merge remote-tracking branch 'origin/brolley/dev' into fche/dev
    
    * origin/brolley/dev:
      Change pmfind/.gitignore to ignore pmfind, not pminfo.
      New client -- pmfind
      Discovery for clients rework.
      pmlogextract - small fixup
      qa/151 - change after fix for pmlogextract bug with dynamic indoms
      qa/532 - change after fix for pmlogextract bug with dynamic indoms
      qa/261 - change after fix for pmlogextract bug with dynamic indoms
      pmlogextract - dynamic indom botch with -S and -T
      pmlogextract/GNUmakefile - add header dependencies
      qa/node_archive archive - needed for qa/768
      qa/768 [new] - pmlogextract bug - reported by Tom Yearke
      pmie/grammar.y - reconcile Ken's and Nathan's overlapping change
      Allow the host part of the host spec to be enclosed in brackets [].
      pmie/grammar.y - add header
      Allow the host part of the host spec to be enclosed in brackets [].
      Service discovery for PCP clients.

commit e8551fafbd0df44174d640ced30c121129047ca8
Merge: 6e20b33 48db577
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Dec 9 15:33:12 2013 -0500

    Merge remote-tracking branch 'origin/dev' into brolley/dev
    
    Conflicts:
        src/include/pcp/impl.h

commit 6e20b3389846f3ab6fdc5600b266f5886622bcfe
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Dec 9 15:12:07 2013 -0500

    Change pmfind/.gitignore to ignore pmfind, not pminfo.

commit b18dfe357333d31ec8f67a4a0619812e2d3ba1da
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Dec 9 15:10:00 2013 -0500

    New client -- pmfind
    
    Skeletal implementation searches for PMCDs on the local
    network.

commit 10452856f33c9414989b5ca4d2f393c1c730ed97
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Dec 9 15:08:01 2013 -0500

    Discovery for clients rework.
    
    - __pmDiscoverServices()
      - Renamed to pmDiscoverServices()
      - Moved from impl.h to pmapi.h
      - discovery_domain is now checked for validity.
        - currently accepted values are NULL and "avahi".
      - Now returns a single freeable buffer
        - Managed by __pmStringListAdd and __pmStringListFind
          - new in internal.h, util.c
      - Output parameter now last
      - Stub now returns -EOPNOTSUPP and ignores urls.
    
    - pmAvahiDiscoverServices()
      - Timeout after 0.5 seconds.
        - This is different than a connection timeout. It's actually the length 
of time that the
          avahi-client will run before reporting. 0.5 seconds is a reasonable 
default. This can now
          be changed by setting AVAHI_DISCOVERY_TIMEOUT in the environment to 
the desired number of
          seconds. Fractions of seconds, down to the millisecond level are 
accepted.
          e.g. AVAHI_DISCOVERY_TIMEOUT=1.175
      - Output parameter now last
      - avahi-client callbacks no longer issue messages. Error code is passed 
back in the
        context object.
    
    - __pmServiceInfoAlloc(), __pmServiceInfoFree(): removed
    
    - __pmServiceInfo, __pmAddDiscoveredService():
      - Moved from impl.h to internal.h
      - Now within HAVE_SERVICE_DISCOVERY block
    
    - __pmServerAdvertisePresence() and __pmServerUnadvertisePresence()
      - Moved to discovery.c from auxserver.c
    
    - temporary -p option removed from pminfo

commit 88247149a3e8e7a2661b691d2ad14fa6c7994718
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Dec 8 18:31:10 2013 -0500

    pmmgr: add a TODO entry

commit fb21fa92dbc207a0cdd2ac855c317b158b54f799
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Dec 8 13:00:54 2013 -0500

    pmmgr: enable Makepkgs

commit 07880888f9e6b2e9b8c68dd64f1427b1a0a861ca
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Dec 8 12:21:02 2013 -0500

    pmmgr: add -r to pmlogger command line options

commit adb4ad75a9f86e87ad62cda8ba16dbc419a93b68
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Dec 8 12:20:30 2013 -0500

    pmmgr: add a default configuration directory under $(PCP_SYSCONF_DIR)/pmmgr

commit e3e1ef8c678a5df2b2ed97100bd7626e3ffeb67c
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Dec 8 00:38:57 2013 -0500

    pmmgr man page: chek spelinng

commit d0c294f36f2ecf6d000209f65cc671d8452c72a5
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Dec 8 00:05:54 2013 -0500

    pmmgr: man/GNUmakefile: install new man page

commit 0769e9963af65265fbd0b3716de5758c3a8af5bc
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Dec 8 00:05:15 2013 -0500

    pmmgr: add man page

commit 4e9bf9b535e9cc1baf36d8192befe6734b452c59
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sat Dec 7 14:26:05 2013 -0500

    pmmgr: make all configuration changeable at run time

commit fd418205f9736ac4a3765283957600b61f725769
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sat Dec 7 14:25:49 2013 -0500

    pmmgr: add TODO file

commit 12ee84e01bbb9e7df57d3b6d0ba4c150453cd348
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sat Dec 7 08:59:29 2013 -0500

    pmmgr: add pmlogmerge-* capability

commit da570f5eb293eb2cca5204615db8b5a9ad7ee729
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Dec 2 20:53:04 2013 -0500

    pmmgr prototype snapshot

commit bef7cdd469d772bba91ffae1703da396fa43e61f
Merge: 9f1b25c dd40ff7
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Thu Dec 5 13:25:48 2013 -0500

    Merge remote-tracking branch 'origin/dev' into brolley/dev
    
    Conflicts:
        src/libpcp/src/auxserver.c
        src/libpcp/src/avahi.c
        src/libpcp/src/avahi.h

commit 9f1b25c8f8971d8e38d488e1b651575d24d9a957
Merge: 032b7ab b4941e6
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Thu Nov 21 14:25:16 2013 -0500

    Merge remote-tracking branch 'origin/dev' into brolley/dev

commit 032b7ab23e85f3dad35f03e169ef536a78b01511
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Thu Nov 21 14:21:04 2013 -0500

    Allow the host part of the host spec to be enclosed in brackets [].
    
    Needed for IPv6 addresses in order to separate the address from the
    port. e.g. pcp://[fe80::5eff:35ff:fe07:55ca]:44321.
    
    For simplicity, the implementation allows the brackets around the
    host part of any spec, as it does no harm. e.g.
    pcp://[10.15.16.212]:44321 or pcp://[some.host]:44321.

commit 31805e25ff278f340179032219a9fbd35d469589
Merge: eaeb067 75db10c
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Nov 19 12:06:07 2013 -0500

    Merge remote-tracking branch 'origin/dev' into brolley/dev

commit eaeb0678cf4e06c77a54cc7cd38401bc9bb250b2
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Tue Nov 19 12:04:14 2013 -0500

    Service discovery for PCP clients.
    
    - New libpcp API function __pmDiscoverServices()
      - Discovers services as requested.
      - Currently, only discovery of PMCD via Avahi is supported.
      - Related new API type: __pmServiceInfo.
      - Related new API functions: __pmServiceInfoAlloc(), 
__pmServiceInfoFree().
      - Related new API functions: __pmAddDisccoveredService(), 
__pmServiceListFree().
    - New __pmSockAddr API function: __pmSockAddrGetPort().
    - Added -p option to pminfo for prototype/testing purposes
      - not intended to be permanent, but can be, if wanted.
      - Instruct pminfo to use __pmDiscoverServices() to search for
        local PMCD servers.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: pmmgr, pmfind, coverity, Nathan Scott <=