pcp
[Top] [All Lists]

pcp updates: scox,kenj,fche,brolley,nathans - megaaa-merge, release prep

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: pcp updates: scox,kenj,fche,brolley,nathans - megaaa-merge, release prep
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 11 Dec 2013 01:47:18 -0500 (EST)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1976937001.28307849.1386744345282.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 1OhbQ5h7dDblTblsjbn7n1pSpKyolw==
Thread-topic: pcp updates: scox,kenj,fche,brolley,nathans - megaaa-merge, release prep
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 CHANGELOG                        |   42 
 build/rpm/GNUmakefile            |    1 
 build/rpm/fedora.spec            |   14 
 build/rpm/pcp.spec.in            |    3 
 configure                        |   33 
 configure.in                     |   17 
 debian/changelog                 |    5 
 man/man1/pmie.1                  |   10 
 man/man3/pmdacache.3             |   15 
 qa/.gitignore                    |    3 
 qa/151                           |   17 
 qa/151.out                       |  201 --
 qa/151.out.1                     |  195 ++
 qa/151.out.2                     |  195 ++
 qa/261                           |    8 
 qa/261.out.3                     |  274 +++
 qa/477                           |    1 
 qa/504                           |    1 
 qa/512                           |   23 
 qa/512.out                       |   32 
 qa/512.out.1                     |   28 
 qa/512.out.2                     |   30 
 qa/529                           |    9 
 qa/532                           |   22 
 qa/532.out                       |  152 --
 qa/532.out.1                     |  150 ++
 qa/532.out.2                     |  150 ++
 qa/536                           |    2 
 qa/575                           |    1 
 qa/660                           |   62 
 qa/750                           |  240 ++-
 qa/750.out                       |  407 ++++-
 qa/768                           |   31 
 qa/768.out                       |   47 
 qa/783                           |  170 +-
 qa/783.out                       |   10 
 qa/GNUmakefile                   |    3 
 qa/check-group                   |   12 
 qa/common.filter                 |    3 
 qa/common.rpm                    |  169 ++
 qa/group                         |   19 
 qa/src/GNUlocaldefs              |    2 
 qa/src/node_archive.0            |binary
 qa/src/node_archive.index        |binary
 qa/src/node_archive.meta         |binary
 qa/valgrind-suppress             |  133 -
 src/include/builddefs.in         |    1 
 src/include/pcp/impl.h           |    1 
 src/include/pcp/pmda.h           |    1 
 src/libpcp/src/auxconnect.c      |    7 
 src/libpcp/src/exports           |    1 
 src/libpcp/src/lock.c            |    7 
 src/libpcp/src/secureconnect.c   |    7 
 src/libpcp/src/spec.c            |   33 
 src/libpcp_fault/README          |   20 
 src/libpcp_fault/src/GNUmakefile |  102 -
 src/libpcp_fault/src/mk.exports  |   14 
 src/libpcp_pmda/src/cache.c      |   36 
 src/pmatop/pmatop.py             |    7 
 src/pmdas/GNUmakefile            |    2 
 src/pmdas/linux/pmda.c           |    2 
 src/pmdas/linux/proc_net_dev.c   |   12 
 src/pmdas/linux_proc/pmda.c      |    2 
 src/pmdas/rpm/.gitignore         |    8 
 src/pmdas/rpm/GNUmakefile        |  153 +-
 src/pmdas/rpm/Install            |   39 
 src/pmdas/rpm/Remove             |   25 
 src/pmdas/rpm/domain.h           |    8 
 src/pmdas/rpm/help               |  235 +--
 src/pmdas/rpm/pmdarpm.python     |  388 ++---
 src/pmdas/rpm/pmns               |  127 +
 src/pmdas/rpm/root               |   10 
 src/pmdas/rpm/rpm.c              | 2875 +++++++++++++++++++++++----------------
 src/pmdas/rpm/rpm.h              |  101 +
 src/pmdas/rpm/timer.c            |   45 
 src/pmdas/rpm/timer.h            |   24 
 src/pmie/pmie_daily.sh           |    5 
 src/pmie/src/grammar.y           |    2 
 src/pmlogextract/GNUmakefile     |    5 
 src/pmlogextract/logger.h        |    1 
 src/pmlogextract/pmlogextract.c  |  114 +
 src/pmns/stdpmid.pcp             |    1 
 src/python/pcp/pmda.py           |    2 
 83 files changed, 4919 insertions(+), 2446 deletions(-)

commit b1c3a4731f737eaa23d7666db9ddbf09e74568cd
Merge: 4b21865 5167590
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 17:42:43 2013 +1100

    Merge branch 'dev' of git://oss.sgi.com/kenj/pcp into dev

commit 4b21865325bff8c8b13e4ba59ed7fbe9491fcaa2
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 17:37:27 2013 +1100

    Add expected output for test 783

commit 51675901e22b838f98806a845e7078598d3e3bfe
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Wed Dec 11 17:21:55 2013 +1100

    libpcp_fault/GNUmakefile - small typo fix from previous commit

commit 0526f9d11cd6ac61f47dc0512851159f29ee9f8c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Wed Dec 11 17:20:59 2013 +1100

    qa/660 - fix IPv6 localhost name discovery, add $seq.full tracing

commit b1b02f3975fdf7e6988e60d53e6bb9a92c451bba
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 16:50:39 2013 +1100

    Update version/changelogs in preparation for a bugfix release

commit b8508d5d3085df77d063b3e12ab8b7fd8d098666
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 15:45:10 2013 +1100

    Different tack toward valgrind testing of pmdarpm, using -C option now

commit ab94ae3641dc45d8ccb28f4d17a2d72c4c39f4a8
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 15:34:59 2013 +1100

    Add a missing header dependency in pmdarpm makefile

commit d8b94730e0ef813754ddc16f16ac20ea82ff98f6
Merge: e4caab7 b1e94cd
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 15:11:37 2013 +1100

    Merge branch 'scox/dev' of ../pcpfans into dev
    
    Conflicts:
        qa/group
    
    (Resolved by taking all new QA tests)

commit e4caab79278f2880ccd832fcb904e882c5565db1
Merge: 48db577 a2993b3
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 15:07:46 2013 +1100

    Merge branch 'dev' of git://oss.sgi.com/kenj/pcp into dev

commit b1e94cd4ad944db546fc517e1e751c887d6115ec
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 22:01:55 2013 -0500

    linux_proc pmda: correct stack blowage during ioctl() for network interfaces
    
    We finally isolated the cause of the peculiar stack-segment
    supergrowth seen occasionally for pmcd on linux, wherein
    multi-gigabyte stacks sometimes briefly appeared on x86-64 hosts.
    Some analysis with systemtap [1] helped pinpoint the linux_proc
    network ioctl()s as causing the problem.  The problem appears to be
    the corruption of the ioctl-argument ifr->ecmd pointer between
    consecutive ioctl()s.  This is now corrected by reinitializing
    before each ioctl().
    
    [1] # stap -e '
    probe kernel.function("acct_stack_growth") {
       if (execname()=="pmcd") {
          println (pn(), " ", $$parms)
          print_backtrace()
          print_ubacktrace()
       }
    }' -d /usr/libexec/pcp/bin/pmcd -d /var/lib/pcp/pmdas/linux/pmda_linux.so 
--ldd
    
    Which reported, inter alia,
    
    kernel.function("acct_stack_growth@mm/mmap.c:2035") grow=0x17d92 
size=0x17db4000 vma=0xffff88009d80b000
     0xffffffff8116c560 : expand_downwards+0xb0/0x240 [kernel]
     0xffffffff8116c714 : expand_stack+0x24/0x40 [kernel]
     0xffffffff8165207f : __do_page_fault+0x43f/0x510 [kernel]
     0xffffffff8165215e : do_page_fault+0xe/0x10 [kernel]
     0xffffffff8164e6d8 : page_fault+0x28/0x30 [kernel]
     0xffffffff81306ae5 : copy_user_generic_string+0x35/0x40 [kernel]
     0xffff88009d8bfe18
     0xffffffff812a72ec : sidtab_context_to_sid+0x30c/0x480 [kernel] (inexact)
     0xffffffff8154a399 : dev_get_by_name_rcu+0x69/0x90 [kernel] (inexact)
     0xffffffff8155f56b : dev_ioctl+0x1ab/0x560 [kernel] (inexact)
     0xffffffff81634d02 : netlbl_domhsh_hash+0x12/0x50 [kernel] (inexact)
     0xffffffff8129e7fc : selinux_file_alloc_security+0x3c/0x60 [kernel] 
(inexact)
     0xffffffff81531195 : sock_do_ioctl+0x45/0x50 [kernel] (inexact)
     0xffffffff815315e0 : sock_ioctl+0x1f0/0x2c0 [kernel] (inexact)
     0xffffffff811b9fdd : do_vfs_ioctl+0x2dd/0x4b0 [kernel] (inexact)
     0xffffffffa0ecba01 [stap_ee080e3c411678e5f019bf218d63791_23997] (inexact)
     0xffffffff811ba231 : SyS_ioctl+0x81/0xa0 [kernel] (inexact)
     0xffffffff81656aa7 : tracesys+0xdd/0xe2 [kernel] (inexact)
     0x2ba833548eb7 : ioctl+0x7/0x30 [/usr/lib64/libc-2.17.so]
     0x2ba8368cfee6 : refresh_proc_net_dev+0x256/0x590 
[/var/lib/pcp/pmdas/linux/pmda_linux.so]
     0x2ba8368c9e2b : linux_refresh+0x39b/0x450 
[/var/lib/pcp/pmdas/linux/pmda_linux.so]
     0x2ba8368c9fe8 : linux_fetch+0x108/0x170 
[/var/lib/pcp/pmdas/linux/pmda_linux.so]
     0x2ba832bbcdf5 : DoFetch+0x585/0x1460 [/usr/libexec/pcp/bin/pmcd]
     0x2ba832bb6a8b : HandleClientInput+0x28b/0x510 [/usr/libexec/pcp/bin/pmcd]
     0x2ba832bb6f03 : ClientLoop+0x1f3/0x6b0 [/usr/libexec/pcp/bin/pmcd]
     0x2ba832bb5a2b : main+0x5db/0x7c0 [/usr/libexec/pcp/bin/pmcd]
     0x2ba83347db45 : __libc_start_main+0xf5/0x1c0 [/usr/lib64/libc-2.17.so]
     0x2ba832bb5c39 : _start+0x29/0x30 [/usr/libexec/pcp/bin/pmcd]

commit 25f86d9ee57d918e39689586d71bc96c0dece451
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 15:00:20 2013 +1100

    Simplify and add to the QA valgrind suppressions file
    
    Discovered the "..." magic incantation which makes several
    things easier in the valgrind suppressions file - able to
    collapse several dlopen cases into one as a result.  Also,
    the pmConfig case becomes easier now (and not hard-coding
    a 32-bit-libraries-only path for some platforms too).
    
    Add in some initial suppressions for readline and NSS from
    testing pmdarpm with dbpmda a bit.

commit be4c07c34df2ce252e181b6dd2147e5c23bf08d4
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 10:56:40 2013 +1100

    Correct bitfield values in PMDA cache code

commit aca8c38fbd5f95868a95405fc38a1ebccb0252d7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 08:53:56 2013 +1100

    Testing suggests the rpm HEADERGET_MINMEM flag is safe for us

commit 666b54361772eb45a1c48ddc22a1282b330256d9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 08:53:20 2013 +1100

    Fix semantics for rpm.datasize and remove dup metrictab entry

commit c3286a6e59c7a526e1170be59fc0743fcd02a311
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Dec 11 08:36:00 2013 +1100

    Move the pmdarpm fetch callback locking to the correct spot

commit 8b367cfb6b442f1e9f7def1999563d48ca5938a0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Wed Dec 11 06:33:36 2013 +1100

    pmie_daily - avoid cron mail chatter
    
    If pmie is chkconfig'd (or equivalent) off, then don't bother emitting
    the message
        logfile directory (...) does not exist
    which is expected.

commit 0b35d89f30f948f2287d0fbf360a69f9c9f8afaf
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 20:58:25 2013 +1100

    qa/536 - /bin/sh is not bash
    
    hinv.{ncpu,ndisk} does not get expanded to anything useful ... oops.

commit 98f94adeb338873ef293a6d3f6b86fa5daa08fde
Merge: a2993b3 48db577
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 20:48:01 2013 +1100

    Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev

commit a2993b3262bb3160774c92dd312af1ec0208dad2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 20:45:33 2013 +1100

    libpcp_fault - make it work again
    
    Changes in libpcp (source files added) and the export symbol hiding
    changes meant that libpcp_fault would no longer build and none of
    the associated QA was being run.
    
    Fixed.

commit 43c064355f03c9007adfad91a6615e0f95c90767
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 20:20:40 2013 +1100

    qa/529 - rework stdin case
    
    Second pmie was not starting ... after sudo -u pcp change?

commit f819230a9f1fe6dec144c9b748f07175a890245c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 17:42:13 2013 +1100

    Initial version of valgrind test for pmdarpm

commit bf4bd2812827c3833a957371fdcd08bedb58a427
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 17:40:32 2013 +1100

    Small cleanup to rpm test qa/750 and common code

commit 76ee1cd73baf33c2886eb0d4e6576e5bd0f09295
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 17:30:34 2013 +1100

    qa/575 - don't remove $PCP_TMP_DIR/pmie

commit 1ea3eca584cc962e072dfe93729a662bb8ad7595
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 16:45:18 2013 +1100

    QA updates for pmdarpm - rejig test 750 in particular
    
    Create a common.rpm script with shell code useful by multiple
    tests, update test 750 to make use of it.  Change test 750 to
    not use python.rpm as its test package but rather now creates
    its own package, with deterministic metadata.
    
    Exercises that an instance domain change is automatically done
    by the pmdarpm background thread on rpm removal as well.

commit 2c567e1e2adcc211709510bee0069ca1bce4f697
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 14:00:30 2013 +1100

    qa/504 - filter fix for $$ -> $seq-$$ change

commit 8e2b2908141b04c772ee5327d93acf79840b5969
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 12:41:20 2013 +1100

    Add pmdarpm to the common QA PMDA filters

commit f4d6d5dd9ffc4319ea311444792144b8124bed7e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 12:20:46 2013 +1100

    Further updates to pmdarpm - use the string cache mechanism
    
    Use string cache support in pmdaCache (allowing spaces in
    keys).  Also wnsure the string cache has been initialised
    before starting the thread which makes use of it.
    
    Further, Stan investigated rpmtdReset and it turns out we
    don't need to be using it at all - we're just immediately
    undoing what it does every time.

commit b088a8b9717abdf19010ae63b6707f358a2e8d5c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 12:16:45 2013 +1100

    Annotate the linux and linux_proc string caches as such

commit b9b30f3ec269f73a6ce7abfab84345d6fd108285
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 12:16:12 2013 +1100

    Add a pmdaCacheOp mechanism for setting a cache as a string cache
    
    Provide an officially supported mechanism for performing string
    de-duplication, now that a third PMDA has found a need for it.  In
    this latest case, for the first time we also see a need for spaces
    in those strings so we need library support for that.

commit 6fb767e2bdeda9cc4998e73a7611747030d3dfbb
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Dec 10 12:11:48 2013 +1100

    Change configure test for rpm header checking, for old versions
    
    Older versions of RHEL (5), predate some of the APIs which pmdarpm
    is making use of.  After chatting to Stan, agreed to configure our
    way out of this little conundrum - so, no pmdarpm will be built or
    installed on those older platforms.

commit 3469e4867d1bc008d0f4836cd2e650ec963110f5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 11:14:53 2013 +1100

    qa/477 - deal with hostname non-determinism from pmevent

commit 28fa2ba40e567fe9858211b747f94c57cd97f7f2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 10:27:50 2013 +1100

    qa/512 and qa/532 - *.out files are now variant

commit ae7f8cf4a2773a28230b0eb9918a3d91724bfec7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 10:26:50 2013 +1100

    qa - add 512 to the fault group

commit 8a3d805af336c96a9829577150bfc42cd4a16b0c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 08:59:47 2013 +1100

    qa/512 - misc changes
    
    1. pmlogger src has moved (needs libpcp_fault installed to expose
       this problem introduced some time ago)
    2. for recent PCP versions, pmlogger has slightly different lock
       fingerprint, so make output version dependent.

commit 83eb015e92f03233e1390a697840a7e21af0a0e6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 07:05:45 2013 +1100

    man/pmie - minor changes to improve consistency in examples

commit a1511d174f485c566db0768a39d28decb83c8ac1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 07:01:13 2013 +1100

    qa/check-group - improve searching logic
    
    1. skip comments in QA tests (was producing false matches)
    2. include / in the prefix characters for the search, so we find
       things like $PCP_BINADM_DIR/pmlogextract

commit 699524d42fe1af0af3f24ad4d5f255ae3b21700e
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Dec 10 07:00:21 2013 +1100

    qa/group - add some tests to the pmlogextract group

commit 21baedd5128d3cf05958880273f097f1a1f1b718
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Dec 9 21:21:33 2013 +1100

    Series of updates to the RPM PMDA and tests
    
    Convert pmdarpm to a fine-grained locking model, where the
    lock is not ever held across RPM API calls.  The fake indom
    discussed onlist has been added to make this work.
    
    Reduce amount of memory required for each package - make use
    of string value sharing (via another pseudo indom) to remove
    string duplication and 32 bit hash table indices are stored
    in place of 64 bit pointers.
    
    The rpm.name metric is removed as this information is already
    available via the instance domain, seems like busy work if we
    dup that as a metric value too.
    
    Correct units for rpm.{buildtime,size,installtime} which has
    the side-effect of rendering the METRICTAB_ENTRY macro not so
    useful anymore - remove it, remove the tag table as thats also
    not needed in the simplified model.
    
    Hide some unconditional diagnostics behind APPL1 debug level.
    
    Add QA test notrun checks for pmdarpm installation, since it
    may not have been built for all platforms.  Both tests need
    further updates, see comments in 750.

commit 7c238c75b29e0ac3213d049b0fb1eda784361ef3
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Dec 9 13:05:04 2013 +1100

    Add rpm.datasize for tracking pmdarpm data segment size

commit d65df6e428780d3da38be800de3659a062abed37
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Dec 9 12:44:16 2013 +1100

    Corrections to pmdarpm help and Install script

commit 3b497d79b5970464f322e12600777069e6c4c00d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Dec 9 11:23:31 2013 +1100

    Add in the missing parts of pmdarpm build process
    
    Update the configure scripts to detect and enable building
    the RPM components for platforms supporting RPM packages.
    Since we're building both DSO and daemon PMDA variants the
    shiny new DSO exports magic for PMDAs is added in as well.
    
    Add install target for the PMDA Install/Remove script.

commit 48db5778694f38ed78dc60ca4789bbcc15926c30
Merge: e2765ea 75700fe
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Dec 9 08:56:27 2013 +1100

    Merge branch 'dev' of git://oss.sgi.com/kenj/pcp into dev

commit 75700feb6205e6272909babcd645c7330d4b9f88
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Mon Dec 9 08:24:43 2013 +1100

    pmlogextract - small fixup
    
    Last commit removed a guard for a a bizarre corner case that qa/460
    exposed ... fixed this and all qa -g pmlogextract and -g logutil
    is now passing.

commit ae13e97482155ac18acf5d9956f78a247a90dbaa
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Mon Dec 9 07:06:33 2013 +1100

    qa/151 - change after fix for pmlogextract bug with dynamic indoms

commit 2fe19a000c64b112d7967b1713c8bb2c36b5c7d1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Mon Dec 9 06:47:23 2013 +1100

    qa/532 - change after fix for pmlogextract bug with dynamic indoms

commit d88f6146a7126ecfc14041eeb4be3dbae05f93fc
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Dec 8 20:26:28 2013 +1100

    qa/261 - change after fix for pmlogextract bug with dynamic indoms

commit c3a29aa8cc6cac17fd67ea1609a0c2242b88ab7c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Dec 8 20:18:28 2013 +1100

    pmlogextract - dynamic indom botch with -S and -T
    
    Reported by Tom Yearke.
    
    When logging a dynamic indom, the timestamps are used to synchronize
    the pmResults with the indom as it changes over time.
    
    The logic was flawed, but requires a corner case to trigger the bug,
    namely:
    1. must have -S on the command line
    2. must have 2 or more indom records in the input archive before the
       -S time
    3. must have a pmResult after the -S time that correctly matches an
       indom record and then one or more additional (consecutive) pmResult
       records that use the _same_ indom state
    
    When this happens, bogus indom records (from before the -S time
    appear in the output archive with modified timestamps to match the
    additional (consecutive) pmResult records.
    
    Fixed by redoing the timestamp accounting and checking as indom
    records are written to the output archive.

commit 18fa110c2d9440d98fdd88450c3782f4dd8e5464
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Dec 8 20:17:35 2013 +1100

    pmlogextract/GNUmakefile - add header dependencies

commit d2faf333ed928e0fcd1d297b3f45b0c09dfc5a2c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Dec 8 20:05:44 2013 +1100

    qa/node_archive archive - needed for qa/768

commit be0179285b309b8c840d918d08e67c6182b440a7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Dec 8 20:01:53 2013 +1100

    qa/768 [new] - pmlogextract bug - reported by Tom Yearke
    
    Corner case ... needs -S, needs dynamic indom, needs more than one
    indom before the -S time, needs two or more consecutive pmResults
    between -S and -T that have the _same_ indom.

commit 22e5ef32a5920c910b2ea0f2bf18e664cb427f84
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Dec 8 19:48:56 2013 +1100

    pmie/grammar.y - reconcile Ken's and Nathan's overlapping change

commit e0cd56047cfa715eac816df5a75486ae9eafad82
Merge: 7ff4acb dd40ff7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Dec 8 17:03:43 2013 +1100

    Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev

commit 19c234491eaccd9648b7b48460e98b8b6caaca94
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Dec 6 17:17:13 2013 +1100

    Initial work on test qa/783 to further exercise pmdarpm

commit e8da686d9ba75c45a1adba95fad8346a16a328ba
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Dec 6 15:56:17 2013 +1100

    Remove committed domain.h for pmdarpm - generated by build

commit 2e03939c53cee25f299a9c0c3e5161f337273aec
Merge: a46fe8a e2765ea
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Dec 6 15:50:38 2013 +1100

    Merge branch 'dev' of ../nathans-pcp into scox/dev

commit a46fe8a0517deaad43cbb9c2431d24dbae38c83c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Dec 6 15:44:28 2013 +1100

    Small cleanups and add missing timing code into pmdarpm
    
    Update test 750 slightly to match what it does, add checks for
    rpm binary, remove references to no-longer-used metrics.
    
    Update the help text file to remove unused metrics, and to just
    use short text (since long help text not adding value here).
    
    Remove the old source of the original pmdarpm python prototype.
    
    Make several globals static, parameterise the path to the rpmdb
    and add a command line option to change it, remove a couple of
    no-longer-used variables, update usage message.
    
    Added in code to do the timing (elapsed, usr/sys) of refreshes.

commit e2765ea7b7f9a0d05fbc28ba663c934d7c91f8ec
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Fri Dec 6 08:47:25 2013 +1100

    Allow the host part of the host spec to be enclosed in brackets [].
    
    Needed for IPv6 addresses in order to separate the address from the
    port. e.g. pcp://[fe80::5eff:35ff:fe07:55ca]:44321.
    
    For simplicity, the implementation allows the brackets around the
    host part of any spec, as it does no harm. e.g.
    pcp://[10.15.16.212]:44321 or pcp://[some.host]:44321.

commit 10faab76c6c77b6d4c36a6ba4da7243644d296c4
Merge: 662ee2e 4dc6698
Author: Stan Cox <scox@xxxxxxxxxx>
Date:   Wed Dec 4 17:55:28 2013 -0500

    Merge branch 'scox/dev' of ssh://sourceware.org/git/pcpfans into scox/dev
    
    Conflicts:
        src/pmdas/rpm/GNUmakefile

commit 662ee2e1dbff6146b9fcf4fa16a710fd7306ae10
Author: Stan Cox <scox@xxxxxxxxxx>
Date:   Wed Dec 4 17:46:21 2013 -0500

    For rpm pmda: simplify caching, use mutexes, improve metric setup.
    
    Remove the separate hash table in favor of pmdaCacheLookupName.  Switched to
    using mutexes since there is only one reader.  Improved the initialization 
of
    metrics.

commit 7ff4acb7cd47abb62944976e3accd53a6305bd09
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Dec 5 08:41:40 2013 +1100

    pmie/grammar.y - add header
    
    Need to #include "systemlog.h" to avoid compilation warnings.

commit 0f0d32eba544ebd12bccaf6dd9ce9d319690881e
Merge: 203e9d6 877c809
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Dec 5 08:29:10 2013 +1100

    Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev

commit 4dc6698b1c3b07336bce08c9ee83f84d4e199541
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Wed Nov 27 15:51:10 2013 -0500

    rpm pmda: don't include unused -lgc in LLDLIBS

commit 4739d33becaf4a16f7d70654265ed6d44a58ea3a
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Mon Nov 18 13:37:21 2013 -0500

    Fix copyright holder for help file

commit 892337118836b9d73ffdfa5a22dfd1b94171325d
Author: Stan Cox <scox@xxxxxxxxxx>
Date:   Wed Nov 27 15:26:54 2013 -0500

    Converted the rpm pmda to cache metrics in advance.
    
    Cache the rpm pmda metrics in advance using data structure 'cache'.
    Build and access via a hash table 'htab'.  Change rpm_fetchCallBack
    to access the cache, via the hash table.

commit 203e9d64bced915ccac06f51ae0423f761fa99bd
Merge: bbbc024 0cfa876
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Mon Nov 25 06:58:32 2013 +1100

    Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev

commit 70437a22172c337a91dd091f511b26576bd70ea5
Author: Stan Cox <scox@xxxxxxxxxx>
Date:   Mon Nov 18 16:05:00 2013 -0500

    Gracefully handle a missing curses module situation.
    
    The curses python module may not be installed so catch and fail gracefully.

commit 0834c974f6f8a41a11184e2d86893e9f975d45d6
Author: Stan Cox <scox@xxxxxxxxxx>
Date:   Mon Nov 18 13:18:15 2013 -0500

    Converted the rpm pmda from python to C.
    
    The rpm pmda was converted to C, which improves the performance for
    fetching the rpm names and loading them as instances.   Added
    associated GNUmakefile changes and namespace table.

commit 967aaeb6faa001c4c5c4864074a4dc852ba912c2
Author: Stan Cox <scox@xxxxxxxxxx>
Date:   Mon Oct 21 22:27:35 2013 -0400

    Add an rpm pmda.
    
    * pmdas/rpm/pmdarpm.python: New file.
    * qa/750: New test.
    * python/pcp/pmda.py (import):  Add addressof

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: scox,kenj,fche,brolley,nathans - megaaa-merge, release prep, Nathan Scott <=