Fix bug reported by Tom Yearke
Changes committed to git://oss.sgi.com/kenj/pcp.git dev
qa/.gitignore | 2
qa/151 | 17 +-
qa/151.out | 6
qa/151.out.1 | 195 ++++++++++++++++++++++++++++
qa/151.out.2 | 195 ++++++++++++++++++++++++++++
qa/261 | 8 -
qa/261.out.3 | 274 ++++++++++++++++++++++++++++++++++++++++
qa/532 | 22 ++-
qa/532.out | 2
qa/532.out.1 | 150 +++++++++++++++++++++
qa/532.out.2 | 150 +++++++++++++++++++++
qa/768 | 31 ++++
qa/768.out | 47 ++++++
qa/group | 1
qa/src/GNUlocaldefs | 2
qa/src/node_archive.0 |binary
qa/src/node_archive.index |binary
qa/src/node_archive.meta |binary
src/pmlogextract/GNUmakefile | 5
src/pmlogextract/logger.h | 1
src/pmlogextract/pmlogextract.c | 114 ++++++++++++----
21 files changed, 1176 insertions(+), 46 deletions(-)
commit 75700feb6205e6272909babcd645c7330d4b9f88
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Dec 9 08:24:43 2013 +1100
pmlogextract - small fixup
Last commit removed a guard for a a bizarre corner case that qa/460
exposed ... fixed this and all qa -g pmlogextract and -g logutil
is now passing.
commit ae13e97482155ac18acf5d9956f78a247a90dbaa
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Dec 9 07:06:33 2013 +1100
qa/151 - change after fix for pmlogextract bug with dynamic indoms
commit 2fe19a000c64b112d7967b1713c8bb2c36b5c7d1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Dec 9 06:47:23 2013 +1100
qa/532 - change after fix for pmlogextract bug with dynamic indoms
commit d88f6146a7126ecfc14041eeb4be3dbae05f93fc
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Dec 8 20:26:28 2013 +1100
qa/261 - change after fix for pmlogextract bug with dynamic indoms
commit c3a29aa8cc6cac17fd67ea1609a0c2242b88ab7c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Dec 8 20:18:28 2013 +1100
pmlogextract - dynamic indom botch with -S and -T
Reported by Tom Yearke.
When logging a dynamic indom, the timestamps are used to synchronize
the pmResults with the indom as it changes over time.
The logic was flawed, but requires a corner case to trigger the bug,
namely:
1. must have -S on the command line
2. must have 2 or more indom records in the input archive before the
-S time
3. must have a pmResult after the -S time that correctly matches an
indom record and then one or more additional (consecutive) pmResult
records that use the _same_ indom state
When this happens, bogus indom records (from before the -S time
appear in the output archive with modified timestamps to match the
additional (consecutive) pmResult records.
Fixed by redoing the timestamp accounting and checking as indom
records are written to the output archive.
commit 18fa110c2d9440d98fdd88450c3782f4dd8e5464
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Dec 8 20:17:35 2013 +1100
pmlogextract/GNUmakefile - add header dependencies
commit d2faf333ed928e0fcd1d297b3f45b0c09dfc5a2c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Dec 8 20:05:44 2013 +1100
qa/node_archive archive - needed for qa/768
commit be0179285b309b8c840d918d08e67c6182b440a7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Dec 8 20:01:53 2013 +1100
qa/768 [new] - pmlogextract bug - reported by Tom Yearke
Corner case ... needs -S, needs dynamic indom, needs more than one
indom before the -S time, needs two or more consecutive pmResults
between -S and -T that have the _same_ indom.
|