pcp
[Top] [All Lists]

Re: [pcp] pcp updates: dso symvers part 2, brolley merge

To: pcp@xxxxxxxxxxx
Subject: Re: [pcp] pcp updates: dso symvers part 2, brolley merge
From: Josh Stone <jistone@xxxxxxxxxx>
Date: Thu, 05 Dec 2013 11:19:17 -0800
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <52A0CF00.1000606@xxxxxxxxxx>
References: <1163802175.23968598.1386225873630.JavaMail.root@xxxxxxxxxx> <52A0CF00.1000606@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 12/05/2013 11:07 AM, Josh Stone wrote:
> On 12/04/2013 10:44 PM, Nathan Scott wrote:
>>     any new internal symbol we add, that cannot be marked static,
>>     should be marked as hidden (see _PCP_HIDDEN in internal.h).
>>     This apparently allows the compiler to deal with it optimally.
>>     This annotation only needs to be made within the header file.
> 
> If you drop the "extern" from such declarations, they should get the
> command-line -fvisibility=hidden automatically, rather than requiring
> this manual attribute notation.

Hmm, maybe not.  I know C functions are implicitly extern, but I thought
gcc treated explicit extern differently in regards to -fvisibility.  I
can't get that to work though, so nevermind...

<Prev in Thread] Current Thread [Next in Thread>