pcp
[Top] [All Lists]

Re: [pcp] First Cut at Avahi Support for PCP Servers

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] First Cut at Avahi Support for PCP Servers
From: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue, 29 Oct 2013 12:45:52 -0400
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1159676587.13325334.1383032522252.JavaMail.root@xxxxxxxxxx>
References: <5251DF3C.7040805@xxxxxxxxxx> <526EAD12.3090904@xxxxxxxxxx> <526EB301.5090501@xxxxxxxxxx> <1159676587.13325334.1383032522252.JavaMail.root@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 10/29/2013 03:42 AM, Nathan Scott wrote:
Hi Dave,


Attached patch tackles the build-configuration detection issue - as
discussed on IRC, be good to use this in that new QA test ...
[ ... ]
Please review & merge as you see fit.  Oh, had some build failures on
your dev branch wrt multiple definitions of some typedefs, fixed here
as well.
Thanks. Reviewed, merged and pushed to brolley/dev
Also, be good to give the new Avahi code a quick read over from a code
consistency POV, its a bit all over the place (even relative to itself,
but also the rest of libpcp).
I took a look. The only thing that stood out for me was naming convention. i.e. the use of lower_case_with_underscore as opposed to mixedCase. I've pushed some changes along these lines. Let me know if there was something more specific on your mind that I missed.

Dave

<Prev in Thread] Current Thread [Next in Thread>