pcp
[Top] [All Lists]

Re: [pcp] First Cut at Avahi Support for PCP Servers

To: Dave Brolley <brolley@xxxxxxxxxx>
Subject: Re: [pcp] First Cut at Avahi Support for PCP Servers
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 29 Oct 2013 03:42:02 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <526EB301.5090501@xxxxxxxxxx>
References: <5251DF3C.7040805@xxxxxxxxxx> <526EAD12.3090904@xxxxxxxxxx> <526EB301.5090501@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: Cmqz5xq1GVy1jZ/wssd01jjnDyPpAg==
Thread-topic: First Cut at Avahi Support for PCP Servers
Hi Dave,

----- Original Message -----
> On 10/28/2013 02:29 PM, Dave Brolley wrote:
> > Hi,
> >
> > Based on feedback received by email I have reworked the code. The work
> > has been pushed to the brolley/dev branch of pcpfans. As of now, these
> > are the relevant, unmerged commits, although the entire branch should
> > be merge-able.
> 
> I forgot to mention that there is some qa fallout associated with new
> messages in the pmcd log that I still need to address.
> 

Attached patch tackles the build-configuration detection issue - as
discussed on IRC, be good to use this in that new QA test ...

$ pmconfig -L
pcp_version=3.8.6
pmapi_version=2
nss_version=3.13.6.0
nspr_version=4.9.2
sasl_version=2.1.23
multi_threaded=true
fault_injection=false
secure_sockets=true
ipv6=true
authentication=true
unix_domain_sockets=true
static_probes=true
service_discovery=true

Please review & merge as you see fit.  Oh, had some build failures on
your dev branch wrt multiple definitions of some typedefs, fixed here
as well.

Also, be good to give the new Avahi code a quick read over from a code
consistency POV, its a bit all over the place (even relative to itself,
but also the rest of libpcp).

cheers.

--
Nathan

Attachment: discovery.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>