pcp
[Top] [All Lists]

pmdagfs2: Minor update and coverity defect fixes

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: pmdagfs2: Minor update and coverity defect fixes
From: Paul Evans <pevans@xxxxxxxxxx>
Date: Thu, 10 Oct 2013 10:13:28 +0100
Cc: PCP Mailing List <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Changes committed to git://github.com/pauljevans/pcp.git dev

 src/pmdas/gfs2/GNUmakefile   |   6 +-
src/pmdas/gfs2/ftrace.c | 159 +++++++++++++++++++++++++++++++++++++++++++
 src/pmdas/gfs2/ftrace.h      |  36 ++++++++++
src/pmdas/gfs2/gfs2_ftrace.c | 156 ------------------------------------------
 src/pmdas/gfs2/gfs2_ftrace.h |  36 ----------
 src/pmdas/gfs2/lock_time.c   |   3 +-
 src/pmdas/gfs2/lock_time.h   |   2 +-
 src/pmdas/gfs2/pmda.c        |  12 ++--
 src/pmdas/gfs2/pmdagfs2.h    |   2 +-
 9 files changed, 210 insertions(+), 202 deletions(-)

commit d4ce171501348c7854d6911179870a3e70ed0437
Author: Paul Evans <pevans@xxxxxxxxxx>
Date:   Thu Oct 10 10:02:05 2013 +0100

    pmdagfs2: Minor update and coverity defect fixes

As suggested by Nathan have reduced the value of GLOCK_ARRAY_CAPACITY to 2048 (from 100000), this should reduce the chance of malloc failing whilst keeping the number of malloc's performed on a system under heavy load to an acceptable level. Renamed gfs2_ftrace(ch) to ftrace(ch) and re-factored the
    change throughout the rest of the code.

    Fixed outstanding CHECKED_RETURN and RESOURCE_LEAK coverity defects for
    pmdagfs2 in ftrace.c and pmda.c respectively and rechecked.

Left NO_EFFECT defect (the only defect left showing for pmdagfs2 on my runs)
    in pmda.c because it is intentional.

Cheers,

Paul

<Prev in Thread] Current Thread [Next in Thread>
  • pmdagfs2: Minor update and coverity defect fixes, Paul Evans <=