Hey Paul,
----- Original Message -----
> Hi,
>
> It's been a while since my last update to pmdagfs2, I've been on PTO for
> the last couple of weeks around Western Europe camping, but in-between
Sounds awesome, where do I sign up? ;)
> been continuing testing on our side with the sas-calibration workloads.
> I plan on following up with a quick succession additional metric updates
> with the rest of the trace_pipe based gfs2 tracepoints as well as
> starting work on a client side tool to bring information for each node
> in the cluster to one central place.
FYI - 3.8.5 is pending, a day or two more if you're keen for it in this
release, else there's always next time. Also, there's a handful of
Coverity-scan-reported issues in pmdagfs2 code if you want to take a
look, else I'll pick 'em up on my way through the rest of the code base.
> Please let me know of any issues and feedback is welcome :).
Couple of small things on review:
- GLOCK_ARRAY_CAPACITY setting seems a little coarse. From some quick
calcs, I think thats going to allocate an ~7-8MB array and then bump
it up by that same amount each time its consumed. Is 100000 glocks
expected to be average/normal? Seems alot ... an alternative scheme
(which is still nice 'n simple & that we use elsewhere too) would be
to start smaller (say 256 glocks), and double the buffer alloc size
on each increment - this tries to balance quickly reaching the point
where the buffer is well-sized for steady state, with consuming less
memory at small glock counts.
- gfs2_ftrace.[ch] - I woulda just named em ftrace.[ch] since we're in
the gfs2 directory here. *shrug*
cheers.
ps: please let me know if there's more planned for within a day or two,
so I can ensure everything gets merged in time ... thanks!
--
Nathan
|