On 25/07/13 13:42, Nathan Scott wrote:
----- Original Message -----
Does that help?
Yes, thanks!
With a permslist hack to dodge the tmpdirs, and a specfile
update (just committed), test 994 now passes with Makepkgs
generated RPMs. Will tweak the fedora.spec next.
Excellent.
diff --git a/qa/src/permslist b/qa/src/permslist
index 59d9eb2..502d07d 100644
--- a/qa/src/permslist
+++ b/qa/src/permslist
@@ -1,13 +1,13 @@
-GNUmakefile|1777|root|root|/var/tmp
+GNUmakefile|1777|root|root|/var/tmp|optional
GNUmakefile|775|pcp|pcp|/var/lib/pcp/config/pmda
GNUmakefile|775|pcp|pcp|/var/run/pcp|optional
src/pmcd/GNUmakefile|775|pcp|pcp|/var/log/pcp/pmcd
src/pmdas/bash/GNUmakefile|1777|root|root|/var/tmp/pmdabash|optional
-src/pmdas/mmv/GNUmakefile|1777|root|root|/var/tmp/mmv
+src/pmdas/mmv/GNUmakefile|1777|root|root|/var/tmp/mmv|optional
src/pmie/GNUmakefile|664|pcp|pcp|/etc/pcp/pmie/control
src/pmie/GNUmakefile|775|pcp|pcp|/etc/pcp/pmie
src/pmie/GNUmakefile|775|pcp|pcp|/var/log/pcp/pmie
-src/pmlogger/GNUmakefile|1777|root|root|/var/tmp/pmlogger
+src/pmlogger/GNUmakefile|1777|root|root|/var/tmp/pmlogger|optional
src/pmlogger/GNUmakefile|664|pcp|pcp|/etc/pcp/pmlogger/control
src/pmlogger/GNUmakefile|775|pcp|pcp|/etc/pcp/pmlogger
src/pmlogger/GNUmakefile|775|pcp|pcp|/var/log/pcp/pmlogger
Yep, if $(INSTALL) is in the scope of this sort of thing ...
ifeq "$(findstring $(PCP_TMP_DIR),/var/tmp /tmp)" ""
then the target should be flagged as optional by mkpermslist and permslist.
|