pcp
[Top] [All Lists]

MySQL logrewriter needed still

To: Chandana De Silva <chandana@xxxxxxxxxxxxx>, Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: MySQL logrewriter needed still
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sat, 20 Jul 2013 00:21:03 -0400 (EDT)
Cc: PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <2020152109.5060445.1374293796936.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: wuFCoNzmtHcFZhHjK60wegLmysxbCA==
Thread-topic: MySQL logrewriter needed still
Hi guys,

Just remembered that it would be desirable to have a log rewrite
rule in place for this next release for the change below.  There
is a git example - src/pmdas/linux_proc/linux_proc_migrate.conf -
that should help, as well other examples on the pmlogrewrite(1)
man page.  Without this, the upgrade will cause you pain, as well
as anyone else logging pmdamysql metrics.

cheers.

--
Nathan


commit bd1a73c200550dbf7af5b177edaf6ee4c1ec908d
Author: Chandana De Silva <chandana@xxxxxxxxxxxxx>
Date:   Mon Jun 24 08:43:27 2013 +1000

    Correct units and type for mysql (active) connection count metric

diff --git a/src/pmdas/mysql/pmdamysql.pl b/src/pmdas/mysql/pmdamysql.pl
index 60905b4..fcd1a1c 100644
--- a/src/pmdas/mysql/pmdamysql.pl
+++ b/src/pmdas/mysql/pmdamysql.pl
@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2012 Chandana De Silva.
+# Copyright (c) 2012-2013 Chandana De Silva.
 # Copyright (c) 2012 Red Hat.
 # Copyright (c) 2008 Aconex.  All Rights Reserved.
 #
@@ -504,7 +504,7 @@ $pmda->add_metric(pmda_pmid(0,109), PM_TYPE_STRING, PM_INDOM
                  PM_SEM_INSTANT, pmda_units(0,0,0,0,0,0),
                  'mysql.status.compression', '', '');
 $pmda->add_metric(pmda_pmid(0,110), PM_TYPE_U32, PM_INDOM_NULL,
-                 PM_SEM_INSTANT, pmda_units(0,0,0,0,0,0),
+                 PM_SEM_COUNTER, pmda_units(0,0,1,0,0,PM_COUNT_ONE),


<Prev in Thread] Current Thread [Next in Thread>