pcp
[Top] [All Lists]

pmdagfs2: Improved distribution support and QA updates

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: pmdagfs2: Improved distribution support and QA updates
From: Paul Evans <pevans@xxxxxxxxxx>
Date: Tue, 16 Jul 2013 18:15:29 +0100
Cc: PCP Mailing List <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Changes commited to git://github.com/pauljevans/pcp.git dev

 qa/654                     |  19 +-
qa/654.out | 561 +--------------------------------------------
 qa/655                     |  21 +-
 qa/common.gfs2             |  25 +-
 src/pmdas/gfs2/Install     |   2 +-
 src/pmdas/gfs2/control.c   |   2 +-
 src/pmdas/gfs2/glocks.c    |  36 ++-
 src/pmdas/gfs2/glstats.c   |  35 ++-
 src/pmdas/gfs2/lock_time.c |   2 +-
 src/pmdas/gfs2/lock_time.h |   2 +-
 src/pmdas/gfs2/pmda.c      |   2 +-
 src/pmdas/gfs2/sbstats.c   |  20 +-
 12 files changed, 114 insertions(+), 613 deletions(-)


commit 3818fd1f36ceae4fe2c48059a7ad475a62e524e9
Author: Paul Evans <pevans@xxxxxxxxxx>
Date:   Tue Jul 16 17:48:07 2013 +0100

    pmdagfs2: Install, set forced_restart=false

    Update Install for pmdagfs2 so that it no longer requires a restart of
    pcp during the installation of the PMDA.

commit 481235623ef82baf452b9abcce85c85f620c78f9
Author: Paul Evans <pevans@xxxxxxxxxx>
Date:   Tue Jul 16 17:47:34 2013 +0100

    pmdagfs2: qa improvements to guarding and compatible setups

    Have reduced the number of tests run on qa/654 so that it can be run
    on most installations with gfs2-utils present. Checked against Fedora
    16-19, Ubuntu 13.04, Centos 6.4 and Debian 7 with Debian 7 being the
    most restrictive through only having support for gfs2.glock metrics.

Included additional checks in qa/655 to test for the mounting of debugfs
    and to attempt to mount it in the event that it is already not. Have
re-added added additional comments on suggestions how to quickly setup a
    configuration for testing 655 in qemu-kvm using the cbox application.

Added additional functions to common.gfs2 that test for the availability of mkfs.gfs2 on the test system (part of gfs2-utils) as well as attempting to
    mount debugfs on distributions that do not have it mounted by default.

qa/654.out reflects the changes made to qa/654 in order to verify a correct
    run.

commit e8a22581f861ce5ad344095b52b4ba66de2c968b
Author: Paul Evans <pevans@xxxxxxxxxx>
Date:   Tue Jul 16 17:46:45 2013 +0100

    pmdagfs2: Improvements for distributions without all gfs2 trace-points

    Improved error handling for distributions that do not currently have
    support for the full set of GFS2 trace-points.

    Additional cases are used within all metrics fetch functions to check
    for a pre-determined value which is set if the trace-point does not
    exist on the system. This sets the metric values as "No Value(s)
    Available" and is a cleaner output than zeros in these cases.

    Also a little spring cleaning with some of the coding conventions.

<Prev in Thread] Current Thread [Next in Thread>