On 03/07/13 14:06, Nathan Scott wrote:
...
I've been working through the issues, but there's one I'd like to
pick your brain over. Test qa/107 is failing now and its because
the pmlogconf generated config uses "log advisory on" and not any
"log mandatory on" clauses (as the old default config did). This
seems to cause test 107 to come away thinking nothing is being
logged at all (pmlc reports "log advisory off" for some reason?)
even though the original config specified "advisory on" and I have
verified that data *is* actually being logged.
Not sure it helps, but "log advisory off" is the default case for
metrics that have never been mentioned in the pmlogger config file, nor
mentioned in a pmlc request to start/change logging.
Is this a pmlc issue? Or should pmlogconf generate configurations
that specify "mandatory on"? Or should the test be changed so it
accepts "adv off nl" as "something is being logged after all"?
I am not seeing this. On a brand new system, with PCP images from
current t-o-t, 107 is passing for me.
and pmlc -P reports thusly which looks ok to me (my config.default is
attached ad definitely came from pmlogconf) ...
pmlc> query disk.all
disk.all.read
adv on 1 min
disk.all.write
adv on 1 min
disk.all.total
adv on 1 min
disk.all.blkread
adv off nl
disk.all.blkwrite
adv off nl
disk.all.blktotal
adv off nl
disk.all.read_bytes
adv on 1 min
disk.all.write_bytes
adv on 1 min
disk.all.total_bytes
adv on 1 min
disk.all.read_merge
adv off nl
disk.all.write_merge
adv off nl
disk.all.avactive
adv on 1 min
disk.all.read_rawactive
adv off nl
disk.all.write_rawactive
adv off nl
disk.all.aveq
adv off nl
pmlc>
Any legal combination of {mandatory,advisory} x {on,off} should be valid
for pmlogger and understood by pmlc ... if not it is a bug.
Also, when pmlogconf generates a configuration file initially (so,
when no pre-existing one found where specified) I've changed it to
add a default [access] section - could you review that too please?
Have attempted to specify no-remote-access-allowed-by-default, and
also no-local-changes-allowed-by-default.
Why no local changes by default? at first blush I'd expect
allow localhost : all;
like pmcd.conf.
config.default
Description: Text document
|