Hi Ken,
The -Wmaybe-uninitialized in lock_time.c are from me. Shall push a patch
to the list now with the changes correcting these.
In the cases mentioned glockA will always be initialised before reaching
the function, however it will be cleaner to have no compilation warnings.
On 06/25/2013 12:54 PM, Ken McDonell wrote:
I'm seeing some new compilations warnings ... could those responsible for the
associated recent code changes please take a look and see if these can be
resolved?
== dpkg-buildpackage: build
contexts.c: In function ‘proc_ctx_revert’:
contexts.c:136:9: warning: ignoring return value of ‘seteuid’, declared with
attribute warn_unused_result [-Wunused-result]
contexts.c:138:9: warning: ignoring return value of ‘setegid’, declared with
attribute warn_unused_result [-Wunused-result]
contexts.c: In function ‘proc_ctx_access’:
contexts.c:119:9: warning: ignoring return value of ‘seteuid’, declared with
attribute warn_unused_result [-Wunused-result]
contexts.c:121:9: warning: ignoring return value of ‘setegid’, declared with
attribute warn_unused_result [-Wunused-result]
lock_time.c: In function ‘gfs2_refresh_lock_time’:
lock_time.c:281:13: warning: ‘glockA.queue’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.queue’ was declared here
lock_time.c:281:13: warning: ‘glockA.dlm’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.dlm’ was declared here
lock_time.c:240:31: warning: ‘glockA.sirtvar’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.sirtvar’ was declared here
lock_time.c:240:31: warning: ‘glockA.sirt’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.sirt’ was declared here
lock_time.c:240:31: warning: ‘glockA.srttvarb’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.srttvarb’ was declared here
lock_time.c:240:31: warning: ‘glockA.srttb’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.srttb’ was declared here
lock_time.c:240:31: warning: ‘glockA.srttvar’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.srttvar’ was declared here
lock_time.c:240:31: warning: ‘glockA.srtt’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.srtt’ was declared here
lock_time.c:240:31: warning: ‘glockA.number’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.number’ was declared here
lock_time.c:240:31: warning: ‘glockA.lock_type’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
lock_time.c:189:30: note: ‘glockA.lock_type’ was declared here
_______________________________________________
pcp mailing list
pcp@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/pcp
Cheers,
Paul
|