On 06/10/2013 07:08 PM, Nathan Scott wrote:
Strictly speaking the macro being used to protect conditional code
compilation should match up with the thing it is protecting. So the
header #include should be protected by HAVE_SYS_UN_H and the use of
socket(AF_UNIX, ...) should be protected by HAVE_AF_UNIX. "Someone"
(i.e. me) was a bit lazy on the latter and went with a pre-existing
platform check macro (IS_MINGW) rather than adding a new configure
macro. We should fix it by adding HAVE_AF_UNIX and make use of that in
the body of the code IMO. Also the error message in that library code
you mentioned should not refer to Windows explicitly, rather it should
say ..., "__pmdaOpenUnix: Not supported on this platform"). cheers. --
Nathan
I want to argue that the presence of the header implies the presence of
the macro, but I don't know if that's actually true.
Dave
|