Hi Nathan,
I've completed another round of changes as based on your comments and
fixed the issues with the QA tests:
Removed the needless on-stack "value" local variable in gfs2_store() and
all other related code belonging to it.
Fixed and improved both QA tests to exercise the pmda 654 and 655. They
have also had their expected outputs recorded into their respective .out
files and changes have been made to common.gfs2 to reflect this.
These changes are available at git://github.com/pauljevans/pcp.git gfs2
On 05/25/2013 03:47 AM, Nathan Scott wrote:
The next steps from there would be:
- A man page for pmdagfs2 would be a good idea, esp. since its a fairly
complex agent - see man/man1/pmdacisco.1 as an example. Description of
the store-to-enable/disable mechanism would be helpful.
- A client tool to drive the extraction and reporting of stats from the
various cluster nodes, manage the enabling / disabling of tracing, etc.
As discussed, python might be an appropriate language (other option is
C), some tests and a man page for the new tool would be a good idea as
well. Looking forward to this - should be an interesting bit of code!
Looking forward these would be the most logical next steps to make,
along with adding additional metrics.
I look forward to feedback.
Regards,
Paul.
|