pcp
[Top] [All Lists]

pcp updates: lvm memleak, qa

To: pcp@xxxxxxxxxxx
Subject: pcp updates: lvm memleak, qa
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 3 Jun 2013 00:35:20 -0400 (EDT)
Delivered-to: pcp@xxxxxxxxxxx
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: oC6jeHyhuxcdcb4KxDsSUJnID52RwA==
Thread-topic: pcp updates: lvm memleak, qa
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 qa/528                      |    2 -
 qa/528.out                  |   45 ++++++++++++++++++--------------------------
 qa/src/batch_import.perl    |   15 ++++----------
 src/pmdas/linux/devmapper.c |    9 +++++---
 4 files changed, 31 insertions(+), 40 deletions(-)

commit 0550e0f716b93be4d4bff6540f75617c8520947b
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Jun 3 14:33:58 2013 +1000

    Fix memory leak on new device mapper instance domain
    
    Thanks to Mark Goodwin for spotting this, we were leaking device
    mapper names on each successive call to hinv.map.lvname.  Also we
    can remove the memset-to-zero after realloc'ing the pmdaInstid
    array since the very next step is to write to all of that memory.

commit cde7dace96b8d2b454aec4ff9a2711cb220c29fa
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Jun 3 14:22:00 2013 +1000

    Fix test 528 which attempted to insert two values for one metric
    
    This results in an error (DUP_METRIC_VALUE) when these are in the
    same pmResult, exposed by Markos recent improvements to the perl
    log import batching.
    
    Also noticed a floating-point rounding issue that would have made
    this test fail on some platforms, so changes to just use strings
    everywhere, since thats simpler and still exercises all of the
    functionality we're after here.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: lvm memleak, qa, Nathan Scott <=