pcp
[Top] [All Lists]

pcp updates: pmimport fix

To: PCP <pcp@xxxxxxxxxxx>
Subject: pcp updates: pmimport fix
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 29 May 2013 06:58:26 -0400 (EDT)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <995558557.14035218.1369824986941.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 3ctHRloxY3JdRpP0lcxJHadVOL7E3w==
Thread-topic: pcp updates: pmimport fix
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 qa/537                         |   40 ++++++++++++++++++++++
 qa/537.out                     |   23 +++++++++++++
 qa/group                       |    1 
 qa/src/GNUlocaldefs            |    2 -
 qa/src/import_limit_test.perl  |   72 +++++++++++++++++++++++++++++++++++++++++
 src/libpcp_import/src/import.c |   26 +++++++++++---
 6 files changed, 157 insertions(+), 7 deletions(-)

commit 90ae8bc5e69e754760a9caa3cd0a18b2de0bc503
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed May 29 20:52:01 2013 +1000

    Remove limit in the libpcp import auto-PMID generation scheme
    
    Marko found that no new metrics could be imported into a log
    beyond 1024.  Turned out to be a lack of pmiAddMetric checks
    for metric counts beyond the PMID "item" space (1<<10).  Its
    now making use of the "cluster" space (1<<12) as well, and I
    added in a check for the real boundary of auto-generated IDs
    which is ~4.2 million metrics.
    
    Test case 537 exercises the fix and makes use of Marko's nice
    succinct test script which exposes the problem.
    
    This resolves Fedora bug 968210.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: pmimport fix, Nathan Scott <=