pcp
[Top] [All Lists]

Re: [pcp] pcp updates: 'collectl2pcp' importer

To: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: 'collectl2pcp' importer
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 15 May 2013 22:42:26 -0400 (EDT)
Cc: pcp <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <5194431B.9050101@xxxxxxxxxx>
References: <5191DB5C.2010708@xxxxxxxxxx> <895660914.3229377.1368664580978.JavaMail.root@xxxxxxxxxx> <5194431B.9050101@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 12P0d7s9b04zeXKpSiKlw5Wa+b4BTg==
Thread-topic: pcp updates: 'collectl2pcp' importer

----- Original Message -----
> On 05/16/2013 10:36 AM, Nathan Scott wrote:
> > Looking good.  Some small stuff from reviewing...
> 
> thanks for that

No worries mate.

> > - the -a option seems a bit wierd in collectl2pcp.c - a mandatory
> > option?  I was expecting syntax more like:
> > $ collect2pcp infile outfile
> 
> how about: collectl2pcp [-v] [-D N] output input [input ...]
> or perhaps collectl2pcp [-v] [-D N] input [input ...] output

The latter syntax matches the name of the command "collectl -> pcp"
so I'd recommend that.

> I'll send out another update with these changes, probably late tonight.

OK; be handy to do the QA test(s) first - since it all works already -
and then you'll be able to check for regressions from all these little
tweaks.  *hint, hint*  ;-)

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>