Hi Ken,
----- Original Message -----
> With these changes I'm almost back to being able to build packages on all my
> QA platforms and starting some QA runs.
Thanks!
> It would be really good if someone with Python expertise reviewed the Python
> changes.
> ...
> The python build was broken in two ways:
> - if PCP is not already installed, then the -L options passed
> through via SETUP_PY_BUILD_OPTIONS += --library-dirs... named
> one directory that did not exist, rather than all the library
> directorties
Hmmm - when I tried the colon-separated library dirs, it didn't work.
Which directory did not exist? (src/lib?) If this does indeed work,
which it appears too ... (?) ... we should remove my workaround which
was the src/lib approach. I'll look into that - thanks.
> - to build pmda.c you need to link with -lpcp_pmda _and_ -lpcp
Good catch, fix looks good.
>
> Non-root PMDA access control changes
>
> PMDAs may run as root, or the user pcp, or some other user and/or
> group (e.g. the dbms PMDAs).
>
> There are two places an arbitrary PMDA needs to be able to write
> 1) $PCP_LOG_DIR/pmcd to create its log file, and
This should not be the case ... agents create their log files before
they drop privileges. Ah, is this the pmcd-sighup case coming back
to haunt us?
I can't foresee any reason why Franks suggestion of making these dirs
group-writable by the "pcp" group would not work ... any thoughts?
> 2) (optionally) $PCP_VAR_DIR/config/pmda to manage any persistant
> instance domain cache files
>
> Both directories need to be mode 1777, but because packaging
> restrictions may get in the way, we uncoditionally set the mode
> on these two directories in the pmcd start up script.
>
> Some PMDAs may need to take additional care with ownership of
> their indom cache files, as the simple PMDA's Install script
> demonstrates.
I've pulled in your commits so we're all sync'd up again, given we're
running up to our 3.8.0 release goal timeframe - but this change does
seem problematic & if we can go for group-writable on these dirs, I'd
vote for that instead.
cheers.
--
Nathan
|