pcp
[Top] [All Lists]

Quite, was Re: Not quite, was Re: pcp-gui patches for QString.toAscii()

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: Quite, was Re: Not quite, was Re: pcp-gui patches for QString.toAscii() un-corruption
From: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Date: Sun, 7 Apr 2013 17:35:44 -0400
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <20130407193913.GE3240@xxxxxxxxxx>
References: <20130407191103.GD3240@xxxxxxxxxx> <20130407193913.GE3240@xxxxxxxxxx>
User-agent: Mutt/1.4.2.2i
Hi -

OK, how about this:

commit c407d0107b50b94b9d893687110d898f87c935ae
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date:   Sun Apr 7 14:55:23 2013 -0400

    QString toAscii decorruption
    
    A recurrent coding pattern in the code aimed to get C "const char*"
    pointers out of QString objects, with code that looks like this:
    
              (const char*) object.toAscii()
    
    This is OK, using the QByteArray conversion-operator, as long as the
    value is used before the QByteArray temporary is itself deleted.
    However, in a few cases, the value is instead stored, or returned,
    leading to corruption and deceit.  These have been reworked:
    [...]


Also on the pcpfans.git fche/pcp-gui branch, ripe for the cherry-plucking,
commit 4e7f2c9c3 and 9162d8c74e.

- FChE

<Prev in Thread] Current Thread [Next in Thread>