pcp
[Top] [All Lists]

Re: Heads-up - overlapped python merge needed soon(ish)

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: Heads-up - overlapped python merge needed soon(ish)
From: Stan Cox <scox@xxxxxxxxxx>
Date: Mon, 01 Apr 2013 16:00:59 -0400
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <165665234.25461192.1364365611984.JavaMail.root@xxxxxxxxxx>
References: <165665234.25461192.1364365611984.JavaMail.root@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
Looks really nice Nathan. Yes I think that is the place for pmsubsys.pl as well as it is shared by both. I think pmsubsys.py is pretty much okay so maybe that and the corresponding changes for pmcollectl.py could be pushed upstream while I tweak on pmatop a bit more.

I am thinking that there is little point in returning status in pmapi.py. All exceptions are raised so it is not needed. The gotcha is that some methods like pmExtractValue are now doing:
 return status, outAtom
would need to be changed to simply
 return outAtom
I was also speculating if it would be handy for pmExtractValue to return multiple values which pmFetch, pmLookupName, pmLookupDesc already do.


<Prev in Thread] Current Thread [Next in Thread>