Hi guys,
I the process of this (on-going), I also came across pcpi.py -
there's a fair bit of code in these "convenience classes", do
we have any sample code that makes use of this code anywhere?
(could it be used as the basis of some tests)
Also, erm, what does/did the "i" stand for? :)
As we have "pmi" (pmlog *i*mport) I was thinking of taking the
opportunity with the pending namespace/pylint shake-up to do
a rename on this module to pcpcc.py (for convenience classes,
as described in the code).
thanks guys!
--
Nathan
----- Original Message -----
> Hi guys,
>
> In considering how to add PMDA APIs to the python PCP code
> (in addition to the existing PMAPI, PMI and pcp-gui wrapper
> code), it seems timely to initially switch to python package
> layout - namespace & subdirectory with multiple .py files.
>
> Also, I've started to tackle the extensive set of pylint(1)
> warnings that we have already accumulated...
>
> nathans@smash:/source/git/pcp$ pylint src/python/setup.py | tail -2
> Your code has been rated at 10.00/10 (previous run: 10.00/10)
> nathans@smash:/source/git/pcp$ pylint src/python/pcp/pmi.py | tail
> -2
> Your code has been rated at 3.94/10 (previous run: 3.94/10)
>
> Any thoughts/review comments much appreciated - thanks!!
>
>
> Changes committed to git://oss.sgi.com/nathans/pcp.git dev
>
> qa/src/check_import.python | 14
> src/python/GNUmakefile | 8
> src/python/pcp.py | 1789
> ---------------------------------------------
> src/python/pcp/.gitignore | 1
> src/python/pcp/GNUmakefile | 25
> src/python/pcp/__init__.py | 1
> src/python/pcp/pcp.py | 1500
> +++++++++++++++++++++++++++++++++++++
> src/python/pcp/pcpi.py | 414 ++++++++++
> src/python/pcp/pmapi.c | 380 +++++++++
> src/python/pcp/pmi.py | 307 +++++++
> src/python/pcpi.py | 414 ----------
> src/python/pmapi.c | 380 ---------
> src/python/setup.py | 73 -
> 13 files changed, 2678 insertions(+), 2628 deletions(-)
>
> commit 93e6c84035eb273b0aed1a02894056f35983a893
> Author: Nathan Scott <nathans@xxxxxxxxxx>
> Date: Fri Mar 15 20:03:31 2013 +1100
>
> Experimental changes to support a pcp python package (!module)
>
|