On 20/03/13 09:14, Nathan Scott wrote:
----- Original Message -----
On 20/03/13 08:07, Nathan Scott wrote:
Something's gone wrong - the non-secure-sockets builds should be
very much how things were before the introduction of NSS code,
and we've never had this warning before. If you can track it down
that would be awesome, else I'll take a look later today.
Found this one ... error in looping logic left fd non-zero, even if
no pmcd socket establised. Tested patch on its way.
Fabulous, thanks!!!
Commit done now ... see previous mail from me.
...
Only thing I can see is that in debian/cleantmpdirs
target="$_new_tmp_dir/$_subdir/$f"
without any tests ... I think any of the following conditions would
warrant a warning (maybe even if $_verbose is not set)
- $_new_tmp_dir does not exist or is not a directory
- $_new_tmp_dir/$_subdir does not exist or is not a directory
- $_new_tmp_dir/$_subdir/$f already exists
I think all of these are handled. This is the postinst, so if we
reach this point the install has succeeded and we are guaranteed
by the packaging that the tmpdirs exist (they are installed now,
during the builds). The final case above remains - that is handled
by the -n option in the mv(1) invocation which is "do not overwrite
an existing file"
OK
|